Conversation
Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
requested review from
Warashi,
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5594 +/- ##
=======================================
Coverage 26.25% 26.25%
=======================================
Files 472 472
Lines 50388 50388
=======================================
Hits 13230 13230
Misses 36097 36097
Partials 1061 1061 ☔ View full report in Codecov by Sentry. |
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
LGTM, can't wait to test this on UI 👀
t-kikuc
left a comment
t-kikuc
left a comment
There was a problem hiding this comment.
LGTM.
I want to confirm one point.
| <Link | ||
| component={RouterLink} | ||
| className={clsx(classes.link, { | ||
| [classes.activeLink]: | ||
| location.pathname === PAGE_PATH_DEPLOYMENT_TRACE, | ||
| })} | ||
| color="inherit" | ||
| to={PAGE_PATH_DEPLOYMENT_TRACE} | ||
| > | ||
| Deployment Traces | ||
| </Link> |
There was a problem hiding this comment.
Just a confirmation. Is it OK to show this button after the next minor release?
Or hide it until some point? (although '/deployment-traces' path will be valid)
There was a problem hiding this comment.
Yes, we should target next minor as release version for this. Along with some other update like form to add application for plugin piped 👀
3 participants
What this PR does:
deployment-tracesList
Deployment-trace-item
Show commit message
Show deployments related
Why we need it:
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: