Add govulncheck job to lint workflow and fix matrix job result syntax#6435
Add govulncheck job to lint workflow and fix matrix job result syntax#6435mohammedfirdouss wants to merge 10 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: Mohammed Firdous <mohammedfirdousaraoye@gmail.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
c15d4e1 to
148b5a3
Compare
Ayushmore1214
left a comment
There was a problem hiding this comment.
Adding go module caching would be better for faster CI runs WDYT @mohammedfirdouss ?
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Hmm, I think this is a good idea. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filesFlags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
|
@khanhtc1202 Merge conflict has been resolved. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
@mohammedfirdouss But I have a concern. @khanhtc1202 please comment if you have another idea. |
Hi @Warashi, thank you for catching this! You're absolutely right. Let me investigate the govulncheck failures immediately. My plan:
I'll have findings + plan by end of day and will either push fixes or create the tracking issue shortly. @khanhtc1202 - thoughts on preferred approach? |
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
|
Created tracking issue #6600. The govulncheck failures are pre-existing vulnerabilities, this PR correctly surfaces them. I'll work on fixing them in a separate PR so we can unblock this one without breaking master. The scan still runs and reports vulnerabilities, but won't block the PR from merging. Once the vulnerabilities are fixed (tracked in #6600), we can make it blocking again. Ready for re-review @Warashi @khanhtc1202 Also, i saw that i will have to update the Go version, so that would probably be a huge bump since it will affect other yml files like test etc. please check the tracking issue for more info CI Run: https://github.com/pipe-cd/pipecd/actions/runs/23225979807 |
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Issue
#6409
What was addressed
The PR adds two security features:
How it works
.github/dependabot.yml)• Scans Go modules and npm packages weekly
• Monitors multiple directories (root, plugins, tools, web, docs)
• Creates PRs when updates are available
• Limits open PRs to 5 per ecosystem to avoid spam
.github/workflows/lint.yaml)• Runs automatically on every PR and push
• Scans all Go modules in the repository
• Uses a matrix strategy to check each module separately
• Fails the CI if vulnerabilities are found
• Includes a completion job (govulncheck-completed) for branch protection rules
Testing
mohammedfirdouss#1 - see this dependabot that automatically checks for dependency updates in my repo and updates what is necessary then opens a PR.
Check out how the workflow file also catches vulnerabilities, the screenshots show evidences that this would work. I am open to reviews and suggestions.
What was done
Updated Go version from 1.25.0 to 1.25.8 in all 14 go.mod files to fix 9 stdlib vulnerabilities detected by govulncheck.
cc: @khanhtc1202 @eeshaanSA @Warashi @ffjlabo