Merge branch 'typescript-rc-merge' into typescript-rc

Author: youssef-saber-3

.github/workflows/cicd_npm-publish.yml

@@ -0,0 +1,14 @@
+name: Publish NPM Packages
+
+on:
+  pull_request:
+    types:
+      - labeled
+
+jobs:
+  publish:
+    if: ${{ github.event.label.name == 'npm-ready-for-publish' }}
+    uses: pipedrive-actions/github-actions-workflows/.github/workflows/reusable_cicd-npm-publish.yml@master
+    with:
+      revision: ${{ github.event.pull_request.head.ref }}
+    secrets: inherit

CHANGELOG.md

@@ -8,13 +8,45 @@ For public Changelog covering all changes done to Pipedrive’s API, webhooks an
 
 ## [Unreleased]
 
-## [23.2.5-rc.2] - 2024-09-03
-### Fixed
-- Updated default values for "billing_frequency_cycles", "billing_start_date" fields
+## [23.4.3] - 2024-11-22
+### Added
+- Add "additionalProperties" to entities with custom fields
+### Changed
+- Updated the code examples in the README for the JavaScript SDK
+### Added
+- Add "custom_fields" query paremeter to GET /api/v2/products
+
+## [23.4.2] - 2024-10-31
+### Changed
+- Updated the code examples in the README for the JavaScript SDK
+### Added
+- Add "custom_fields" query paremeter to GET /api/v2/products
 
-## [23.2.5-rc.1] - 2024-09-02
-### Updated
--  Updated TypeScript interfaces
+## [23.4.1] - 2024-10-09
+
+### Changed
+- Migrate publish flow from Jenkins to GitHub Actions
+- Add devops-tooling as owner for .github/workflows/cicd_*
+
+## [23.4.0] - 2024-09-24
+### Changed
+- Added the field "notes" to product prices in the body and response for v1 and v2
+- Added the field "overhead_cost" to the product variation prices in the response for v1
+- Added the field "direct_cost" to the product variation prices in the response and body for v2
+
+## [23.3.0] - 2024-09-23
+### Added
+- Add documentation for installments functionality:
+  - `POST` `/v1/deals/{id}/products` endpoint
+  - `PUT` `/v1/deals/{id}/products/{product_attachment_id}` endpoint
+  - `DELETE` `/v1/deals/{id}/products/{product_attachment_id}` endpoint
+  - `POST` `/v2/deals/{id}/products` endpoint
+  - `PATCH` `/v2/deals/{id}/products/{product_attachment_id}` endpoint
+  - `DELETE` `/v2/deals/{id}/products/{product_attachment_id}` endpoint
+
+## [23.2.6] - 2024-09-06
+### Fixed
+- Deleted unused file with long name
 
 ## [23.2.5] - 2024-08-27
 ### Fixed
@@ -687,6 +719,11 @@ structure
 
 [Unreleased]: https://github.com/pipedrive/api-docs/compare/v23.2.5-rc.2...HEAD
 [23.2.5-rc.2]: https://github.com/pipedrive/api-docs/compare/v23.2.5...v23.2.5-rc.2
+[23.4.3]: https://github.com/pipedrive/api-docs/compare/v23.4.2...v23.4.3
+[23.4.2]: https://github.com/pipedrive/api-docs/compare/v23.4.1...v23.4.2
+[23.4.1]: https://github.com/pipedrive/api-docs/compare/v23.4.0...v23.4.1
+[23.4.0]: https://github.com/pipedrive/api-docs/compare/v23.3.0...v23.4.0
+[23.3.0]: https://github.com/pipedrive/api-docs/compare/v23.2.5...v23.3.0
 [23.2.5]: https://github.com/pipedrive/api-docs/compare/v23.2.4...v23.2.5
 [23.2.4]: https://github.com/pipedrive/api-docs/compare/v23.2.3...v23.2.4
 [23.2.3]: https://github.com/pipedrive/api-docs/compare/v23.2.2...v23.2.3

CODEOWNERS

@@ -0,0 +1 @@
+.github/workflows/cicd_* @pipedrive/devops-tooling

Jenkinsfile

@@ -13,7 +13,7 @@ Name | Type | Description | Notes
 **selectable** | **Boolean** | Whether this product can be selected in deals or not | [optional] [default to true]
 **visible_to** | [**VisibleTo**](VisibleTo.md) | The visibility of the product. If omitted, the visibility will be set to the default visibility setting of this item type for the authorized user. Read more about visibility groups <a href=\"https://support.pipedrive.com/en/article/visibility-groups\" target=\"_blank\" rel=\"noopener noreferrer\">here</a>.<h4>Essential / Advanced plan</h4><table><tr><th style=\"width: 40px\">Value</th><th>Description</th></tr><tr><td>`1`</td><td>Owner & followers</td><tr><td>`3`</td><td>Entire company</td></tr></table><h4>Professional / Enterprise plan</h4><table><tr><th style=\"width: 40px\">Value</th><th>Description</th></tr><tr><td>`1`</td><td>Owner only</td><tr><td>`3`</td><td>Owner's visibility group</td></tr><tr><td>`5`</td><td>Owner's visibility group and sub-groups</td></tr><tr><td>`7`</td><td>Entire company</td></tr></table> | [optional] 
 **owner_id** | **Number** | The ID of the user who will be marked as the owner of this product. When omitted, the authorized user ID will be used | [optional] 
-**prices** | **[Object]** | An array of objects, each containing: `currency` (string), `price` (number), `cost` (number, optional), `overhead_cost` (number, optional). Note that there can only be one price per product per currency. When `prices` is omitted altogether, a default price of 0 and a default currency based on the company's currency will be assigned. | [optional] 
+**prices** | **[Object]** | An array of objects, each containing: `currency` (string), `price` (number), `cost` (number, optional), `overhead_cost` (number, optional), `notes` (string, optional). Note that there can only be one price per product per currency. When `prices` is omitted altogether, a default price of 0 and a default currency based on the company's currency will be assigned. | [optional] 
 **billing_frequency** | [**BillingFrequency1**](BillingFrequency1.md) |  | [optional] 
 **billing_frequency_cycles** | **Number** | Only available in Advanced and above plans  The number of times the billing frequency repeats for a product in a deal  When `billing_frequency` is set to `one-time`, this field must be `null`  For all the other values of `billing_frequency`, `null` represents a product billed indefinitely  Must be a positive integer less or equal to 312  | [optional] 
 

docs/AddProductRequestBody.md

@@ -13,7 +13,7 @@ Name | Type | Description | Notes
 **comments** | **String** | A textual comment associated with this product-deal attachment | [optional] 
 **tax** | **Number** | The tax percentage | [optional] [default to 0]
 **tax_method** | **String** | The tax option to be applied to the products. When using `inclusive`, the tax percentage will already be included in the price. When using `exclusive`, the tax will not be included in the price. When using `none`, no tax will be added. Use the `tax` field for defining the tax percentage amount | [optional] 
-**enabled_flag** | **Boolean** | Whether the product is enabled for a deal or not. This makes it possible to add products to a deal with a specific price and discount criteria, but keep them disabled, which refrains them from being included in the deal value calculation. When omitted, the product will be marked as enabled by default | [optional] [default to true]
+**enabled_flag** | **Boolean** | Whether the product is enabled for a deal or not  This makes it possible to add products to a deal with a specific price and discount criteria, but keep them disabled, which refrains them from being included in the deal value calculation. When omitted, the product will be marked as enabled by default  Not possible to disable the product if the deal has installments associated and the product is the last one enabled  Not possible to enable the product if the deal has installments associated and the product is recurring  | [optional] [default to true]
 
 
 

docs/DealProductRequestBody.md

@@ -432,7 +432,7 @@ Name | Type | Description  | Notes
 
 Delete an attached product from a deal
 
-Deletes a product attachment from a deal, using the `product_attachment_id`.
+Deletes a product attachment from a deal, using the `product_attachment_id`  Not possible to delete the attached product if the deal has installments associated and the product is the last one enabled 
 
 ### Example
 

docs/DealsApi.md

@@ -5,7 +5,7 @@
 Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
 **success** | **Boolean** | If the response is successful or not | [optional] 
-**data** | [**[Field]**](Field.md) |  | [optional] 
+**data** | [**[GetField]**](GetField.md) |  | [optional] 
 **additional_data** | [**AdditionalData**](AdditionalData.md) |  | [optional] 
 
 

docs/FieldsResponse.md

@@ -4,7 +4,7 @@
 
 Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
-**data** | [**[Field]**](Field.md) |  | [optional] 
+**data** | [**[GetField]**](GetField.md) |  | [optional] 
 **additional_data** | [**AdditionalData**](AdditionalData.md) |  | [optional] 
 
 

docs/FieldsResponseAllOf.md

@@ -5,7 +5,7 @@
 Name | Type | Description | Notes
 ------------ | ------------- | ------------- | -------------
 **success** | **Boolean** | If the response is successful or not | [optional] 
-**data** | [**[ProductField]**](ProductField.md) | Array containing data for all product fields | [optional] 
+**data** | [**[GetProductField]**](GetProductField.md) | Array containing data for all product fields | [optional] 
 **additional_data** | **Object** | Additional data for the product field, such as pagination | [optional]