Skip to content

[TRST-1.2-R1] Silent override of userdefined flags via alias --with-comet introduces configuration ambiguity #536

@0xHansLee

Description

@0xHansLee

Description and context

In client/cmd/cmd.go-72-85, the aliasWithComet function unconditionally sets the --with-comet flag to match the value of --with-tendermint if the latter is present. This logic does not verify whether --with-comet was already explicitly defined by the user. As a result, user-specified configurations such as --with-comet=false --with-tendermint=true will lead to --with-comet being silently overridden to true. This behavior risks violating user intent and could affect security-critical configurations that depend on these flags.

Suggested solution

We recommend checking if --with-comet has already been explicitly defined before overwriting it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions