fix: avoid mistaken linked libraries as binaries

Author: pirafrank

src/files/filesys.rs

@@ -42,6 +42,7 @@ pub fn find_exec_files_in_dir(dir: &Path, deep: bool) -> Vec<PathBuf> {
                 if file_type.is_dir() {
                     stack.push(entry.path());
                 } else if file_type.is_file()
+                    && is_likely_a_binary(&entry.path())
                     && ((deep && is_exec_for_current_arch(&entry.path()).unwrap_or(false))
                         || (!deep && is_exec_by_magic_number(&entry.path())))
                 {
@@ -56,6 +57,41 @@ pub fn find_exec_files_in_dir(dir: &Path, deep: bool) -> Vec<PathBuf> {
     result
 }
 
+/// Return `true` when `path` is a likely a binary file.
+///
+/// A binary file is a file with a known extension that is likely to be a binary file.
+/// It is not a binary file if it has no extension or if it has an extension that is
+/// not a known binary extension.
+/// Known library extensions are: .so, .dylib, .a, .lib, .dll.
+///
+/// # Arguments
+///
+/// * `path` - The path to the file to check.
+///
+/// # Returns
+///
+/// * `true` if the file is a likely a binary file, `false` otherwise.
+pub fn is_likely_a_binary(path: &Path) -> bool {
+    // if no extension, it's likely a binary file.
+    // fast-track most common case.
+    if path.extension().is_none() {
+        return true;
+    }
+    // else, we guess!
+    if path.extension().is_some()
+        && (path.extension().unwrap().to_string_lossy().to_lowercase() == "so"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "dylib"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "a"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "o"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "obj"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "lib"
+            || path.extension().unwrap().to_string_lossy().to_lowercase() == "dll")
+    {
+        return false;
+    }
+    true
+}
+
 /// Return `true` when `path` is a regular file with at least one executable bit set (Unix only).
 #[cfg(not(target_os = "windows"))]
 pub fn is_executable(path: &PathBuf) -> bool {