refactor: enhance editPositionButton functionality to support multiple selections and improve search query handling

Author: pitzzahh

src/main/java/ui/ViewPosition.java

@@ -92,26 +92,26 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
         jPanel1.setLayout(new org.netbeans.lib.awtextra.AbsoluteLayout());
 
         positionsTable.setModel(new javax.swing.table.DefaultTableModel(
-            new Object [][] {
+                new Object[][]{
 
-            },
-            new String [] {
-                "ID", "Postion Name", "Salary", "Description", "Created At"
-            }
+                },
+                new String[]{
+                        "ID", "Postion Name", "Salary", "Description", "Created At"
+                }
         ) {
-            Class[] types = new Class [] {
-                java.lang.Integer.class, java.lang.String.class, java.lang.String.class, java.lang.String.class, java.lang.String.class
+            Class[] types = new Class[]{
+                    java.lang.Integer.class, java.lang.String.class, java.lang.String.class, java.lang.String.class, java.lang.String.class
             };
-            boolean[] canEdit = new boolean [] {
-                false, false, false, false, false
+            boolean[] canEdit = new boolean[]{
+                    false, false, false, false, false
             };
 
             public Class getColumnClass(int columnIndex) {
-                return types [columnIndex];
+                return types[columnIndex];
             }
 
             public boolean isCellEditable(int rowIndex, int columnIndex) {
-                return canEdit [columnIndex];
+                return canEdit[columnIndex];
             }
         });
         positionsTable.getTableHeader().setReorderingAllowed(false);
@@ -278,14 +278,29 @@ private void deletePositionButtonActionPerformed(java.awt.event.ActionEvent evt)
     }//GEN-LAST:event_deletePositionButtonActionPerformed
 
     private void editPositionButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_editPositionButtonActionPerformed
-        int selectedRow = positionsTable.getSelectedRow();
-        if (selectedRow == -1) return;
-        int positionId = (int) positionsTable.getValueAt(selectedRow, 0);
-        PositionDetails positionDetails = (PositionDetails) HumanResourceInformationSystem.FRAMES.get(Windows.POSITION_DETAILS).get();
-        positionDetails.openHrEditPosition(positionId);
+        int[] selectedRows = positionsTable.getSelectedRows();
+        if (selectedRows.length == 0) return;
+
+        if (selectedRows.length == 1) {
+            // Single selection: hide ViewPosition and use canonical instance
+            int positionId = (int) positionsTable.getValueAt(selectedRows[0], 0);
+            PositionDetails positionDetails = (PositionDetails) HumanResourceInformationSystem.FRAMES.get(Windows.POSITION_DETAILS).get();
+            setVisible(false);
+            positionDetails.openForHrFromViewPositions(positionId);
+        } else {
+            // Multiple selection: create new instances for each, ViewPosition stays visible
+            for (int selectedRow : selectedRows) {
+                final int positionId = (int) positionsTable.getValueAt(selectedRow, 0);
+                SwingUtilities.invokeLater(() -> {
+                    PositionDetails positionDetails = new PositionDetails();
+                    positionDetails.openHrEditPositionMultiple(positionId);
+                });
+            }
+        }
     }//GEN-LAST:event_editPositionButtonActionPerformed
 
     private void refreshButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_refreshButtonActionPerformed
+        final String QUERY = searchField.getText();
         if (Validator.isEmptyOrNullString(searchField.getText())) {
             DefaultTableModel positionsTableModel = Util.UI.clearAndGetTableModel(Util.UI.getTableModel(positionsTable), () -> {
                 editPositionButton.setEnabled(false);
@@ -299,41 +314,42 @@ private void refreshButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN
                     );
             return;
         }
+        if (QUERY.contains("Search position by")) return;
         searchButtonActionPerformed(evt);
     }//GEN-LAST:event_refreshButtonActionPerformed
 
     private void searchButtonActionPerformed(java.awt.event.ActionEvent evt) {//GEN-FIRST:event_searchButtonActionPerformed
-        String query = searchField.getText();
+        final String QUERY = searchField.getText();
         String filter = filters.getItemAt(filters.getSelectedIndex());
-        if (Validator.isEmptyOrNullString(query)) {
-            JOptionPane.showMessageDialog(this, "Please enter your search query and choose search filter", "Warning", JOptionPane.WARNING_MESSAGE);
+        if (Validator.isEmptyOrNullString(QUERY)) {
+            JOptionPane.showMessageDialog(this, "Please enter your search QUERY and choose search filter", "Warning", JOptionPane.WARNING_MESSAGE);
             return;
         }
         DefaultTableModel model = Util.UI.clearAndGetTableModel(Util.UI.getTableModel(positionsTable));
         if (Objects.equals(filter, "Name")) {
             HumanResourceInformationSystem.POSITION_SERVICE
-                    .getPositionByName(query)
+                    .getPositionByName(QUERY)
                     .thenAccept(positions -> addPositions(positions, model))
                     .exceptionally(throwable -> {
                         JOptionPane.showMessageDialog(this, throwable.getMessage(), "Error", JOptionPane.ERROR_MESSAGE);
                         throw new RuntimeException(throwable);
                     });
         } else if (Objects.equals(filter, "Salary")) {
 
-            if (!Validator.isNumber(query)) {
-                JOptionPane.showMessageDialog(this, "Salary query must be a number", "Warning", JOptionPane.WARNING_MESSAGE);
+            if (!Validator.isNumber(QUERY)) {
+                JOptionPane.showMessageDialog(this, "Salary QUERY must be a number", "Warning", JOptionPane.WARNING_MESSAGE);
                 return;
             }
             HumanResourceInformationSystem.POSITION_SERVICE
-                    .getPositionBySalary(Double.parseDouble(query))
+                    .getPositionBySalary(Double.parseDouble(QUERY))
                     .thenAccept(positions -> addPositions(positions, model))
                     .exceptionally(throwable -> {
                         JOptionPane.showMessageDialog(this, throwable.getMessage(), "Error", JOptionPane.ERROR_MESSAGE);
                         throw new RuntimeException(throwable);
                     });
         } else if (Objects.equals(filter, "Description")) {
             HumanResourceInformationSystem.POSITION_SERVICE
-                    .getPositionByDescription(query)
+                    .getPositionByDescription(QUERY)
                     .thenAccept(positions -> addPositions(positions, model))
                     .exceptionally(throwable -> {
                         JOptionPane.showMessageDialog(this, throwable.getMessage(), "Error", JOptionPane.ERROR_MESSAGE);