Reduce memory usage when calculating release shasum

geofffranks · davewalter · commit 1d7b2de01e32 · 2024-11-12T09:48:53.000-08:00
diff --git a/pkg/cargo/bosh_release.go b/pkg/cargo/bosh_release.go
@@ -155,7 +155,7 @@ func ReadBOSHReleaseTarball(tarballPath string, r io.Reader) (BOSHReleaseTarball
 	if err != nil {
 		return BOSHReleaseTarball{}, err
 	}
-	_, err = io.ReadAll(r)
+	_, err = io.CopyBuffer(io.Discard, r, make([]byte, 1024 * 64))
 	return BOSHReleaseTarball{
 		Manifest: m,
 		SHA1:     hex.EncodeToString(sum.Sum(nil)),

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ func ReadBOSHReleaseTarball(tarballPath string, r io.Reader) (BOSHReleaseTarball`
`155`	`155`	`if err != nil {`
`156`	`156`	`return BOSHReleaseTarball{}, err`
`157`	`157`	`}`
`158`		`- _, err = io.ReadAll(r)`
	`158`	`+ _, err = io.CopyBuffer(io.Discard, r, make([]byte, 1024 * 64))`
`159`	`159`	`return BOSHReleaseTarball{`
`160`	`160`	`Manifest: m,`
`161`	`161`	`SHA1: hex.EncodeToString(sum.Sum(nil)),`