fix cases

Author: nahsra

.dccache

@@ -0,0 +1 @@
+{"/Users/arshan/code/bad-java-code/pom.xml":[3000,1718917349969.081,"4ca0de2d17b12b52ecf638bd3529d914f1f750898f876269d182ab79cf74728a"],"/Users/arshan/code/bad-java-code/src/main/java/com/acme/XXEVuln.java":[2982,1719002214286.9138,"5e87995eedebe28ff93049eea7e7807851dcfeb40e05f74af61b5eae351b6de2"],"/Users/arshan/code/bad-java-code/src/main/java/com/acme/XXEVulnFixed.java":[3603,1719002288827.916,"c736fde04ea3864ea1a1d7dc680491b0005fc4e71921e4f78baf0929e9569ec9"],"/Users/arshan/code/bad-java-code/src/main/java/com/acme/reflection/TranslatorStrategy.java":[182,1718917349970.476,"aaebffa4316c4b698bb186d80bccd0b1344ddd1bd837f96cea34a08b5003ccf2"],"/Users/arshan/code/bad-java-code/src/main/java/com/acme/reflection/UnsafeReflection.java":[1755,1718917349970.8848,"bb2d13e795f710d48ba7232694f994257c4ed72b36329e0365ba430092efe784"],"/Users/arshan/code/bad-java-code/src/main/java/com/acme/reflection/UnsafeReflectionFixed.java":[1789,1718917349971.234,"fa8dc9b96ec62f8db22c208a9f2cd20fd219f0115bfd51aaae023c56c3028f00"]}

src/main/java/com/acme/XXEVuln.java

@@ -31,7 +31,7 @@ public static void main(String[] args)
     saxTransformer(args[0]);
     withDom(args[1]);
     withDomButDisabled(args[2]);
-    withReaderFactory(null);
+    withReaderFactory(args[3]);
 
     String sql = "select * from users where name= '" + args[0] + "'";
     Connection conn = DriverManager.getConnection("jdbc:mysql://localhost/test");
@@ -78,8 +78,9 @@ public static Document withDomButDisabled(String xml)
     return db.parse(new InputSource(new StringReader(xml)));
   }
 
-  public static XMLReader withReaderFactory(XMLReaderFactory factory)
-      throws ParserConfigurationException, IOException, SAXException {
-    return factory.createXMLReader();
+  public static void withReaderFactory(String xml)
+      throws IOException, SAXException {
+    XMLReader reader = XMLReaderFactory.createXMLReader();
+    reader.parse(new InputSource(new StringReader(xml)));
   }
 }

src/main/java/com/acme/XXEVulnFixed.java

@@ -32,7 +32,7 @@ public static void main(String[] args)
     saxTransformer(args[0]);
     withDom(args[1]);
     withDomButDisabled(args[2]);
-    withReaderFactory(null);
+    withReaderFactory(args[3]);
 
     String sql = "select * from users where name= '" + args[0] + "'";
     Connection conn = DriverManager.getConnection("jdbc:mysql://localhost/test");
@@ -86,8 +86,9 @@ public static Document withDomButDisabled(String xml)
     return db.parse(new InputSource(new StringReader(xml)));
   }
 
-  public static XMLReader withReaderFactory(XMLReaderFactory factory)
-      throws ParserConfigurationException, IOException, SAXException {
-    return factory.createXMLReader();
+  public static void withReaderFactory(String xml)
+      throws IOException, SAXException {
+    XMLReader reader = XMLReaderFactory.createXMLReader();
+    reader.parse(new InputSource(new StringReader(xml)));
   }
 }