🐛 add missing importance property to test codemods

Author: ryandens

framework/codemodder-base/src/test/java/io/codemodder/CLITest.java

@@ -222,7 +222,10 @@ void file_finder_works() throws IOException {
   }
 
   /** This codemod just replaces Java file contents with the word "cloud9" */
-  @Codemod(id = "org:java/cloud9", reviewGuidance = ReviewGuidance.MERGE_AFTER_REVIEW)
+  @Codemod(
+      id = "org:java/cloud9",
+      reviewGuidance = ReviewGuidance.MERGE_AFTER_REVIEW,
+      importance = Importance.LOW)
   private static class Cloud9Changer extends RawFileChanger {
     private Cloud9Changer() {
       super(UselessReportStrategy.INSTANCE);

framework/codemodder-base/src/test/java/io/codemodder/CodemodLoaderTest.java

@@ -22,10 +22,16 @@
 
 final class CodemodLoaderTest {
 
-  @Codemod(id = "test_mod", reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
+  @Codemod(
+      id = "test_mod",
+      importance = Importance.LOW,
+      reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class InvalidCodemodName extends NoReportChanger {}
 
-  @Codemod(id = "pixee:java/id", reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
+  @Codemod(
+      id = "pixee:java/id",
+      importance = Importance.LOW,
+      reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class ValidCodemod extends NoReportChanger {}
 
   private static class NoReportChanger implements CodeChanger {
@@ -72,6 +78,7 @@ void it_blows_up_on_duplicate_codemod_ids(@TempDir Path tmpDir) {
   @Codemod(
       id = "test:java/changes-file",
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW,
+      importance = Importance.LOW,
       executionPriority = CodemodExecutionPriority.HIGH)
   static class ChangesFile extends RawFileChanger {
     ChangesFile() {
@@ -110,6 +117,7 @@ public String getIndividualChangeDescription(Path filePath, CodemodChange change
 
   @Codemod(
       id = "test:java/changes-file-again",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class ChangesFileAgain extends RawFileChanger {
 
@@ -150,6 +158,7 @@ public String getIndividualChangeDescription(Path filePath, CodemodChange change
   @Codemod(
       id = "test:java/changes-file-yet-again",
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW,
+      importance = Importance.LOW,
       executionPriority = CodemodExecutionPriority.LOW)
   static class ChangesFileYetAgain extends RawFileChanger {
 
@@ -239,6 +248,7 @@ void it_handles_consecutive_codemod_changes(@TempDir Path tmpDir) throws IOExcep
 
   @Codemod(
       id = "pixee:java/parameterized",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class ParameterizedCodemod extends RawFileChanger {
     private final Parameter parameter;

framework/codemodder-base/src/test/java/io/codemodder/javaparser/JavaParserCodemodRunnerTest.java

@@ -166,7 +166,10 @@ void it_composes_successfully() throws IOException {
     assertThat(Files.readString(javaFile), is(updatedCode));
   }
 
-  @Codemod(reviewGuidance = ReviewGuidance.MERGE_AFTER_REVIEW, id = "pixee-test:java/my-composite")
+  @Codemod(
+      reviewGuidance = ReviewGuidance.MERGE_AFTER_REVIEW,
+      importance = Importance.LOW,
+      id = "pixee-test:java/my-composite")
   private static class RunsBothCodemod extends CompositeJavaParserChanger {
     @Inject
     public RunsBothCodemod(

plugins/codemodder-plugin-pmd/src/test/java/io/codemodder/providers/sarif/pmd/PmdModuleTest.java

@@ -46,6 +46,7 @@ public abstract class MultipleDeclarations {
 
   @Codemod(
       id = "pmd-test:java/my-pmd-codemod",
+      importance = Importance.HIGH,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesPmdCodemod extends SarifPluginJavaParserChanger<VariableDeclarator> {
     private final RuleSarif ruleSarif;

plugins/codemodder-plugin-semgrep/src/test/java/io/codemodder/providers/sarif/semgrep/SemgrepJavaParserChangerTest.java

@@ -59,6 +59,7 @@ private Path writeJavaFile(final Path tmpDir, final String javaCode) throws IOEx
 
   @Codemod(
       id = "pixee-test:java/uses-inline-semgrep",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesInlineSemgrepCodemod extends SarifPluginJavaParserChanger<ObjectCreationExpr> {
 

plugins/codemodder-plugin-semgrep/src/test/java/io/codemodder/providers/sarif/semgrep/SemgrepModuleTest.java

@@ -38,6 +38,7 @@ final class SemgrepModuleTest {
 
   @Codemod(
       id = "pixee-test:java/implicit-yaml",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesImplicitYamlPath implements CodeChanger {
     private final RuleSarif ruleSarif;
@@ -70,6 +71,7 @@ public String getIndividualChangeDescription(Path filePath, CodemodChange change
 
   @Codemod(
       id = "pixee-test:java/explicit-yaml-test",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesExplicitYamlPath extends SarifPluginJavaParserChanger<ObjectCreationExpr> {
 
@@ -99,6 +101,7 @@ public boolean onResultFound(
 
   @Codemod(
       id = "pixee-test:java/missing-properties-test",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class MissingYamlPropertiesPath extends SarifPluginJavaParserChanger<ObjectCreationExpr> {
 
@@ -133,6 +136,7 @@ public boolean onResultFound(
 
   @Codemod(
       id = "pixee-test:java/uses-implicit-rule",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesImplicitRule extends SarifPluginJavaParserChanger<ObjectCreationExpr> {
 
@@ -263,6 +267,7 @@ void it_works_with_offline_semgrep(@TempDir Path tmpDir) throws IOException {
 
   @Codemod(
       id = "pixee-test:java/offline-semgrep",
+      importance = Importance.LOW,
       reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
   static class UsesOfflineSemgrepCodemod implements CodeChanger {
 

plugins/codemodder-plugin-semgrep/src/test/java/io/codemodder/providers/sarif/semgrep/invalid/bindstoincorrect/BindsToIncorrectObject.java

@@ -3,6 +3,7 @@
 import io.codemodder.CodeChanger;
 import io.codemodder.Codemod;
 import io.codemodder.CodemodChange;
+import io.codemodder.Importance;
 import io.codemodder.ReviewGuidance;
 import io.codemodder.codetf.CodeTFReference;
 import io.codemodder.providers.sarif.semgrep.SemgrepScan;
@@ -14,6 +15,7 @@
 /** An invalid codemod that binds SARIF to a non-SARIF object. */
 @Codemod(
     id = "pixee-test:java/incorrect-binding-type",
+    importance = Importance.HIGH,
     reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
 public final class BindsToIncorrectObject implements CodeChanger {
   @Inject

plugins/codemodder-plugin-semgrep/src/test/java/io/codemodder/providers/sarif/semgrep/invalid/bothyamlstrategies/InvalidUsesBothYamlStrategies.java

@@ -13,6 +13,7 @@
  */
 @Codemod(
     id = "pixee-test:java/both-yaml",
+    importance = Importance.LOW,
     reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
 public final class InvalidUsesBothYamlStrategies
     extends SarifPluginJavaParserChanger<ObjectCreationExpr> {

plugins/codemodder-plugin-semgrep/src/test/java/io/codemodder/providers/sarif/semgrep/invalid/implicitbutmultiplerules/UsesImplicitButHasMultipleRules.java

@@ -13,6 +13,7 @@
  */
 @Codemod(
     id = "pixee-test:java/uses-implicit-rule",
+    importance = Importance.LOW,
     reviewGuidance = ReviewGuidance.MERGE_AFTER_CURSORY_REVIEW)
 public class UsesImplicitButHasMultipleRules
     extends SarifPluginJavaParserChanger<ObjectCreationExpr> {