Add fix for tab-oriented confusion (#369)

This result for the `AddClarifyingBracesCodemod` was confusing, because
it shouldn't act on the statement. There's no visual confusion in the
single statement within the if block.

The math the codemod does for calculating the offsets involved and
deciding to change is based on column number. This makes sense if the
code is written with spaces, not tabs. With tabs, the "visual layout" of
the code depends on the viewer, and the offsets would require different
math at a minimum. Our workaround is to ignore cases that involve tabs
for now until we get a better design to accommodate tabs.

<img width="434" alt="image"
src="https://github.com/pixee/codemodder-java/assets/911610/9de959b0-d952-42a9-b673-54716a513a47">

Author: nahsra

core-codemods/src/main/java/io/codemodder/codemods/AddClarifyingBracesCodemod.java

@@ -9,6 +9,7 @@
 import com.github.javaparser.ast.stmt.IfStmt;
 import com.github.javaparser.ast.stmt.Statement;
 import com.github.javaparser.ast.stmt.WhileStmt;
+import com.github.javaparser.printer.lexicalpreservation.LexicalPreservingPrinter;
 import io.codemodder.*;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sarif.pmd.PmdScan;
@@ -76,6 +77,13 @@ private ChangesResult handleUnbracedStmt(final UnbracedStatement stmt) {
     Range onlyInnerStatementRange = stmt.getExistingSingleStatementRange();
     int onlyInnerStatementColumn = onlyInnerStatementRange.begin.column;
 
+    String concreteStatementCode = LexicalPreservingPrinter.print(stmt.getStatement());
+    if (concreteStatementCode.contains("\t")) {
+      // if the statement contains tabs, we don't want to touch it -- tabs confuse the visual layout
+      // because we can't go by "column" -- it will depend on the viewer
+      return ChangesResult.noChanges;
+    }
+
     if (nextChildNodeBeginColumn >= onlyInnerStatementColumn) {
       stmt.addBraces();
       return ChangesResult.changesApplied;

core-codemods/src/test/resources/add-clarifying-braces/BigTabRegression.java.before

@@ -0,0 +1,12 @@
+package com.acme;
+
+abstract class Foo {
+
+    private void loadApplications() {
+        if(m_authProvider.isTokenExpired())
+			return;
+
+        m_applications = new HashMap<String, String>();
+        String url =  m_authProvider.getServer() + ASE_APPS+"?columns=name";
+	}
+}