Skip to content

Commit 43abbea

Browse files
authored
Reduce redundant reporting logic (#385)
Forgot that we had a utility for sharing reporting logic across different codemods -- this cleans that up for SQLi, which has the sprawl.
1 parent b62d73f commit 43abbea

File tree

7 files changed

+7
-44
lines changed

7 files changed

+7
-44
lines changed

core-codemods/src/main/java/io/codemodder/codemods/DefectDojoSqlInjectionCodemod.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public final class DefectDojoSqlInjectionCodemod extends JavaParserChanger
3131
public DefectDojoSqlInjectionCodemod(
3232
@DefectDojoScan(ruleId = "java.lang.security.audit.sqli.jdbc-sqli.jdbc-sqli")
3333
RuleFindings findings) {
34+
super(CodemodReporterStrategy.fromClasspath(SQLParameterizerCodemod.class));
3435
this.findings = Objects.requireNonNull(findings);
3536
this.remediatorStrategy = JavaParserSQLInjectionRemediatorStrategy.DEFAULT;
3637
}

core-codemods/src/main/java/io/codemodder/codemods/SonarSQLInjectionCodemod.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public final class SonarSQLInjectionCodemod extends SonarRemediatingJavaParserCh
2626
@Inject
2727
public SonarSQLInjectionCodemod(
2828
@ProvidedSonarScan(ruleId = "java:S2077") final RuleHotspot hotspots) {
29+
super(CodemodReporterStrategy.fromClasspath(SQLParameterizerCodemod.class));
2930
this.hotspots = Objects.requireNonNull(hotspots);
3031
this.remediationStrategy = JavaParserSQLInjectionRemediatorStrategy.DEFAULT;
3132
}

core-codemods/src/main/resources/io/codemodder/codemods/DefectDojoSqlInjectionCodemod/description.md

Lines changed: 0 additions & 13 deletions
This file was deleted.

core-codemods/src/main/resources/io/codemodder/codemods/DefectDojoSqlInjectionCodemod/report.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

core-codemods/src/main/resources/io/codemodder/codemods/SonarSQLInjectionCodemod/description.md

Lines changed: 0 additions & 13 deletions
This file was deleted.

core-codemods/src/main/resources/io/codemodder/codemods/SonarSQLInjectionCodemod/report.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

plugins/codemodder-plugin-sonar/src/main/java/io/codemodder/providers/sonar/SonarRemediatingJavaParserChanger.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,17 @@
11
package io.codemodder.providers.sonar;
22

3+
import io.codemodder.CodemodReporterStrategy;
34
import io.codemodder.FixOnlyCodeChanger;
45
import io.codemodder.javaparser.JavaParserChanger;
56

67
/** Provides base functionality for making JavaParser-based remediation of Sonar results. */
78
public abstract class SonarRemediatingJavaParserChanger extends JavaParserChanger
89
implements FixOnlyCodeChanger {
910

11+
protected SonarRemediatingJavaParserChanger(final CodemodReporterStrategy reporter) {
12+
super(reporter);
13+
}
14+
1015
@Override
1116
public String vendorName() {
1217
return "Sonar";

0 commit comments

Comments
 (0)