Modifications to read both types of sonar findings: issues and hotspots (#378)

Read data using issues and hotspots parent abstract class:
`SonarFinding`.

This change will allow us to start creating sonar hotspots codemods

Author: carlosu7

core-codemods/src/main/java/io/codemodder/codemods/AddMissingOverrideCodemod.java

@@ -8,7 +8,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -20,16 +20,17 @@
     reviewGuidance = ReviewGuidance.MERGE_WITHOUT_REVIEW,
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
-public final class AddMissingOverrideCodemod extends SonarPluginJavaParserChanger<SimpleName> {
+public final class AddMissingOverrideCodemod
+    extends SonarPluginJavaParserChanger<SimpleName, Issue> {
 
   @Inject
   public AddMissingOverrideCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1161") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1161") final RuleIssue issues) {
     super(issues, SimpleName.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final SimpleName methodName,

core-codemods/src/main/java/io/codemodder/codemods/AvoidImplicitPublicConstructorCodemod.java

@@ -12,7 +12,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -25,16 +25,16 @@
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class AvoidImplicitPublicConstructorCodemod
-    extends SonarPluginJavaParserChanger<SimpleName> {
+    extends SonarPluginJavaParserChanger<SimpleName, Issue> {
 
   @Inject
   public AvoidImplicitPublicConstructorCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1118") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1118") final RuleIssue issues) {
     super(issues, SimpleName.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final SimpleName simpleName,

core-codemods/src/main/java/io/codemodder/codemods/DeclareVariableOnSeparateLineCodemod.java

@@ -10,7 +10,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -23,15 +23,15 @@
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class DeclareVariableOnSeparateLineCodemod
-    extends SonarPluginJavaParserChanger<VariableDeclarator> {
+    extends SonarPluginJavaParserChanger<VariableDeclarator, Issue> {
   @Inject
   public DeclareVariableOnSeparateLineCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1659") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1659") final RuleIssue issues) {
     super(issues, VariableDeclarator.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final VariableDeclarator variableDeclarator,

core-codemods/src/main/java/io/codemodder/codemods/DefineConstantForLiteralCodemod.java

@@ -6,7 +6,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import javax.inject.Inject;
@@ -18,16 +18,16 @@
     importance = Importance.HIGH,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class DefineConstantForLiteralCodemod
-    extends SonarPluginJavaParserChanger<StringLiteralExpr> {
+    extends SonarPluginJavaParserChanger<StringLiteralExpr, Issue> {
 
   @Inject
   public DefineConstantForLiteralCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1192") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1192") final RuleIssue issues) {
     super(issues, StringLiteralExpr.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final StringLiteralExpr stringLiteralExpr,

core-codemods/src/main/java/io/codemodder/codemods/FixRedundantStaticOnEnumCodemod.java

@@ -6,7 +6,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import javax.inject.Inject;
@@ -18,16 +18,16 @@
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class FixRedundantStaticOnEnumCodemod
-    extends SonarPluginJavaParserChanger<EnumDeclaration> {
+    extends SonarPluginJavaParserChanger<EnumDeclaration, Issue> {
 
   @Inject
   public FixRedundantStaticOnEnumCodemod(
-      @ProvidedSonarScan(ruleId = "java:S2786") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S2786") final RuleIssue issues) {
     super(issues, EnumDeclaration.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final EnumDeclaration enumDecl,

core-codemods/src/main/java/io/codemodder/codemods/HardenStringParseToPrimitivesCodemod.java

@@ -9,7 +9,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -50,11 +50,11 @@ private static Optional<String> determineParsingMethodForType(final String type)
    * or new Float("12").
    */
   private static final class HardenParseForConstructorChanger
-      extends SonarPluginJavaParserChanger<ObjectCreationExpr> {
+      extends SonarPluginJavaParserChanger<ObjectCreationExpr, Issue> {
 
     @Inject
     public HardenParseForConstructorChanger(
-        @ProvidedSonarScan(ruleId = "java:S2130") final RuleIssues issues) {
+        @ProvidedSonarScan(ruleId = "java:S2130") final RuleIssue issues) {
       super(
           issues,
           ObjectCreationExpr.class,
@@ -63,7 +63,7 @@ public HardenParseForConstructorChanger(
     }
 
     @Override
-    public ChangesResult onIssueFound(
+    public ChangesResult onFindingFound(
         final CodemodInvocationContext context,
         final CompilationUnit cu,
         final ObjectCreationExpr objectCreationExpr,
@@ -112,11 +112,11 @@ public DetectorRule detectorRule() {
    * Integer or Float classes.
    */
   private static final class HardenParseForValueOfChanger
-      extends SonarPluginJavaParserChanger<MethodCallExpr> {
+      extends SonarPluginJavaParserChanger<MethodCallExpr, Issue> {
 
     @Inject
     public HardenParseForValueOfChanger(
-        @ProvidedSonarScan(ruleId = "java:S2130") final RuleIssues issues) {
+        @ProvidedSonarScan(ruleId = "java:S2130") final RuleIssue issues) {
       super(
           issues,
           MethodCallExpr.class,
@@ -125,7 +125,7 @@ public HardenParseForValueOfChanger(
     }
 
     @Override
-    public ChangesResult onIssueFound(
+    public ChangesResult onFindingFound(
         final CodemodInvocationContext context,
         final CompilationUnit cu,
         final MethodCallExpr methodCallExpr,

core-codemods/src/main/java/io/codemodder/codemods/OverridesMatchParentSynchronizationCodemod.java

@@ -8,7 +8,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -24,16 +24,16 @@
     importance = Importance.MEDIUM,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class OverridesMatchParentSynchronizationCodemod
-    extends SonarPluginJavaParserChanger<SimpleName> {
+    extends SonarPluginJavaParserChanger<SimpleName, Issue> {
 
   @Inject
   public OverridesMatchParentSynchronizationCodemod(
-      @ProvidedSonarScan(ruleId = "java:S3551") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S3551") final RuleIssue issues) {
     super(issues, SimpleName.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       CodemodInvocationContext context, CompilationUnit cu, SimpleName methodName, Issue issue) {
     Optional<Node> parentNodeRef = methodName.getParentNode();
     if (parentNodeRef.isPresent()) {

core-codemods/src/main/java/io/codemodder/codemods/RemoveCommentedCodeCodemod.java

@@ -6,7 +6,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import javax.inject.Inject;
@@ -22,7 +22,7 @@
     reviewGuidance = ReviewGuidance.MERGE_WITHOUT_REVIEW,
     importance = Importance.HIGH,
     executionPriority = CodemodExecutionPriority.HIGH)
-public final class RemoveCommentedCodeCodemod extends SonarPluginJavaParserChanger<Comment> {
+public final class RemoveCommentedCodeCodemod extends SonarPluginJavaParserChanger<Comment, Issue> {
 
   /**
    * The reason behind this specific region node matcher is that in the reported column by
@@ -36,13 +36,13 @@ public final class RemoveCommentedCodeCodemod extends SonarPluginJavaParserChang
 
   @Inject
   public RemoveCommentedCodeCodemod(
-      @ProvidedSonarScan(ruleId = "java:S125") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S125") final RuleIssue issues) {
 
     super(issues, Comment.class, regionNodeMatcher, NodeCollector.ALL_COMMENTS);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final Comment comment,

core-codemods/src/main/java/io/codemodder/codemods/RemoveRedundantVariableCreationCodemod.java

@@ -7,7 +7,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import java.util.Optional;
@@ -20,16 +20,16 @@
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class RemoveRedundantVariableCreationCodemod
-    extends SonarPluginJavaParserChanger<ObjectCreationExpr> {
+    extends SonarPluginJavaParserChanger<ObjectCreationExpr, Issue> {
 
   @Inject
   public RemoveRedundantVariableCreationCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1488") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1488") final RuleIssue issues) {
     super(issues, ObjectCreationExpr.class);
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       final CodemodInvocationContext context,
       final CompilationUnit cu,
       final ObjectCreationExpr objectCreationExpr,

core-codemods/src/main/java/io/codemodder/codemods/RemoveUnusedImportCodemod.java

@@ -12,7 +12,7 @@
 import io.codemodder.codetf.DetectorRule;
 import io.codemodder.javaparser.ChangesResult;
 import io.codemodder.providers.sonar.ProvidedSonarScan;
-import io.codemodder.providers.sonar.RuleIssues;
+import io.codemodder.providers.sonar.RuleIssue;
 import io.codemodder.providers.sonar.SonarPluginJavaParserChanger;
 import io.codemodder.sonar.model.Issue;
 import javax.inject.Inject;
@@ -23,11 +23,11 @@
     importance = Importance.LOW,
     executionPriority = CodemodExecutionPriority.HIGH)
 public final class RemoveUnusedImportCodemod
-    extends SonarPluginJavaParserChanger<ImportDeclaration> {
+    extends SonarPluginJavaParserChanger<ImportDeclaration, Issue> {
 
   @Inject
   public RemoveUnusedImportCodemod(
-      @ProvidedSonarScan(ruleId = "java:S1128") final RuleIssues issues) {
+      @ProvidedSonarScan(ruleId = "java:S1128") final RuleIssue issues) {
     super(
         issues,
         ImportDeclaration.class,
@@ -42,7 +42,7 @@ public RemoveUnusedImportCodemod(
   }
 
   @Override
-  public ChangesResult onIssueFound(
+  public ChangesResult onFindingFound(
       CodemodInvocationContext context, CompilationUnit cu, ImportDeclaration node, Issue issue) {
     if (issue.getMessage().contains(node.getNameAsString())) {
       return cu.remove(node) ? ChangesResult.changesApplied : ChangesResult.noChanges;