Define a constant for a literal string that is duplicated n times (Sonar)

Author: pixeebot[bot]

plugins/codemodder-plugin-maven/src/main/java/io/codemodder/plugins/maven/operator/CompositeDependencyManagement.java

@@ -30,13 +30,13 @@ public boolean execute(ProjectModel pm) {
 
     // add dependencyManagement
     Element dependencyManagementElement;
-    if (parentPomFile.getResultPom().getRootElement().elements("dependencyManagement").isEmpty()) {
+    if (parentPomFile.getResultPom().getRootElement().elements(DEPENDENCYMANAGEMENT).isEmpty()) {
       dependencyManagementElement =
           Util.addIndentedElement(
-              parentPomFile.getResultPom().getRootElement(), parentPomFile, "dependencyManagement");
+              parentPomFile.getResultPom().getRootElement(), parentPomFile, DEPENDENCYMANAGEMENT);
     } else {
       dependencyManagementElement =
-          parentPomFile.getResultPom().getRootElement().element("dependencyManagement");
+          parentPomFile.getResultPom().getRootElement().element(DEPENDENCYMANAGEMENT);
     }
 
     Element newDependencyManagementElement =
@@ -93,10 +93,10 @@ private Element modifyDependency(
       return (Element) dependencyNodes.get(0);
     } else {
       Element dependenciesNode;
-      if (parentElement.element("dependencies") != null) {
-        dependenciesNode = parentElement.element("dependencies");
+      if (parentElement.element(DEPENDENCIES) != null) {
+        dependenciesNode = parentElement.element(DEPENDENCIES);
       } else {
-        dependenciesNode = Util.addIndentedElement(parentElement, pomFileToModify, "dependencies");
+        dependenciesNode = Util.addIndentedElement(parentElement, pomFileToModify, DEPENDENCIES);
       }
 
       Element dependencyNode =
@@ -118,4 +118,8 @@ private Element modifyDependency(
       return dependencyNode;
     }
   }
+  
+  private static final String DEPENDENCYMANAGEMENT = "dependencyManagement";
+  
+  private static final String DEPENDENCIES = "dependencies";
 }

plugins/codemodder-plugin-maven/src/main/java/io/codemodder/plugins/maven/operator/QueryByParsing.java

@@ -79,15 +79,15 @@ private void updateDependencyManagement(POMDocument pomDocument) {
         String groupId = getElementTextOrNull(dependencyElement, "groupId");
         String artifactId = getElementTextOrNull(dependencyElement, "artifactId");
         String version =
-            Optional.ofNullable(dependencyElement.elementText("version")).orElse("UNKNOWN");
+            Optional.ofNullable(dependencyElement.elementText("version")).orElse(UNKNOWN);
         String classifier = getElementTextOrNull(dependencyElement, "classifier");
         String packaging = getElementTextOrNull(dependencyElement, "packaging");
 
         try {
           version = strSubstitutor.replace(version);
         } catch (IllegalStateException e) {
           logger.warn("while interpolating version", e);
-          version = "UNKNOWN";
+          version = UNKNOWN;
         }
 
         Dependency dependency =
@@ -122,7 +122,7 @@ private void updateDependencies(POMDocument pomDocument) {
         String groupId = getElementTextOrNull(dependencyElement, "groupId");
         String artifactId = getElementTextOrNull(dependencyElement, "artifactId");
         String version =
-            Optional.ofNullable(dependencyElement.elementText("version")).orElse("UNKNOWN");
+            Optional.ofNullable(dependencyElement.elementText("version")).orElse(UNKNOWN);
 
         Dependency proposedDependency = lookForDependencyManagement(groupId, artifactId);
 
@@ -136,7 +136,7 @@ private void updateDependencies(POMDocument pomDocument) {
             version = strSubstitutor.replace(version);
           } catch (IllegalStateException e) {
             logger.warn("while interpolating version", e);
-            version = "UNKNOWN";
+            version = UNKNOWN;
           }
 
           Dependency dependency =
@@ -191,4 +191,6 @@ private void updateProperties(POMDocument pomDocument) {
   private static final Pattern RE_INTERPOLATION =
       Pattern.compile(".*\\$\\{[\\p{Alnum}.\\-_]+\\}.*");
   private static final Logger logger = LoggerFactory.getLogger(QueryByParsing.class);
+  
+  private static final String UNKNOWN = "UNKNOWN";
 }

plugins/codemodder-plugin-semgrep/src/main/java/io/codemodder/providers/sarif/semgrep/DefaultSemgrepRuleFactory.java

@@ -29,7 +29,7 @@ public SemgrepRule createRule(
 
     if (!declaredRuleId.isEmpty()) {
       String classpathYamlPath =
-          "/" + packageName.replace(".", "/") + "/" + declaredRuleId + ".yaml";
+          "/" + packageName.replace(".", "/") + "/" + declaredRuleId + YAML;
 
       if (!"".equals(yamlPath)) {
         classpathYamlPath = yamlPath;
@@ -100,7 +100,7 @@ private void addMissingPropertiesIfNeeded(Path yamlPathToWrite) throws IOExcepti
   /** Save the YAML string given to a temporary file. */
   private Path saveStringToTemp(final String yamlAsString) {
     try {
-      Path file = Files.createTempFile("semgrep", ".yaml");
+      Path file = Files.createTempFile("semgrep", YAML);
       Files.writeString(file, yamlAsString);
       return file;
     } catch (IOException e) {
@@ -119,7 +119,7 @@ private Optional<Path> saveClasspathResourceToTemp(
       return Optional.empty();
     }
     try {
-      Path semgrepRuleFile = Files.createTempFile("semgrep", ".yaml");
+      Path semgrepRuleFile = Files.createTempFile("semgrep", YAML);
       Objects.requireNonNull(ruleInputStream);
       Files.copy(ruleInputStream, semgrepRuleFile, StandardCopyOption.REPLACE_EXISTING);
       ruleInputStream.close();
@@ -146,4 +146,6 @@ static String detectSingleRuleFromYaml(final String rawYaml) {
     int end = rawYaml.indexOf("\n", start);
     return rawYaml.substring(start + ruleIdStartToken.length(), end).trim();
   }
+  
+  private static final String YAML = ".yaml";
 }