compilation

Author: nahsra

core-codemods/src/main/java/io/codemodder/codemods/HQLParameterizationCodemod.java

@@ -47,11 +47,13 @@ private Optional<CodemodChange> onNodeFound(
   }
 
   @Override
-  public List<CodemodChange> visit(
+  public CodemodFileScanningResult visit(
       final CodemodInvocationContext context, final CompilationUnit cu) {
-    return cu.findAll(MethodCallExpr.class).stream()
-        .flatMap(mce -> onNodeFound(context, mce, cu).stream())
-        .collect(Collectors.toList());
+    List<CodemodChange> changes =
+        cu.findAll(MethodCallExpr.class).stream()
+            .flatMap(mce -> onNodeFound(context, mce, cu).stream())
+            .collect(Collectors.toList());
+    return CodemodFileScanningResult.withOnlyChanges(changes);
   }
 
   private static final String queryParameterNamePrefix = ":parameter";

core-codemods/src/main/java/io/codemodder/codemods/SQLParameterizerCodemod.java

@@ -32,10 +32,12 @@ private Optional<CodemodChange> onNodeFound(final MethodCallExpr methodCallExpr)
   }
 
   @Override
-  public List<CodemodChange> visit(
+  public CodemodFileScanningResult visit(
       final CodemodInvocationContext context, final CompilationUnit cu) {
-    return cu.findAll(MethodCallExpr.class).stream()
-        .flatMap(mce -> onNodeFound(mce).stream())
-        .collect(Collectors.toList());
+    List<CodemodChange> changes =
+        cu.findAll(MethodCallExpr.class).stream()
+            .flatMap(mce -> onNodeFound(mce).stream())
+            .collect(Collectors.toList());
+    return CodemodFileScanningResult.withOnlyChanges(changes);
   }
 }

core-codemods/src/main/java/io/codemodder/codemods/SpringAbsoluteCookieTimeoutCodemod.java

@@ -8,7 +8,6 @@
 import java.nio.file.Path;
 import java.time.Duration;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
@@ -48,12 +47,13 @@ public SpringAbsoluteCookieTimeoutCodemod(
   }
 
   @Override
-  public List<CodemodChange> visitFile(final CodemodInvocationContext context) throws IOException {
+  public CodemodFileScanningResult visitFile(final CodemodInvocationContext context)
+      throws IOException {
     Path path = context.path();
     if (!"application.properties".equalsIgnoreCase(path.getFileName().toString())) {
-      return List.of();
+      return CodemodFileScanningResult.none();
     } else if (!inExpectedDir(context.codeDirectory().asPath().relativize(path))) {
-      return List.of();
+      return CodemodFileScanningResult.none();
     }
 
     List<CodemodChange> changes = new ArrayList<>();
@@ -93,9 +93,9 @@ public List<CodemodChange> visitFile(final CodemodInvocationContext context) thr
 
     if (!changes.isEmpty()) {
       Files.write(path, lines);
-      return Collections.unmodifiableList(changes);
+      return CodemodFileScanningResult.withOnlyChanges(changes);
     }
-    return List.of();
+    return CodemodFileScanningResult.none();
   }
 
   private boolean inExpectedDir(final Path relativePath) {

core-codemods/src/main/java/io/codemodder/codemods/VerbTamperingCodemod.java

@@ -34,13 +34,15 @@ public VerbTamperingCodemod(final XPathStreamProcessor processor) {
   }
 
   @Override
-  public List<CodemodChange> visitFile(final CodemodInvocationContext context) throws IOException {
+  public CodemodFileScanningResult visitFile(final CodemodInvocationContext context)
+      throws IOException {
     Path file = context.path();
     if (!"web.xml".equalsIgnoreCase(file.getFileName().toString())) {
-      return List.of();
+      return CodemodFileScanningResult.none();
     }
     try {
-      return processWebXml(context, file);
+      List<CodemodChange> changes = processWebXml(context, file);
+      return CodemodFileScanningResult.withOnlyChanges(changes);
     } catch (SAXException | DocumentException | XMLStreamException e) {
       throw new IOException("Problem transforming web.xml", e);
     }