Skip to content

Commit 964f558

Browse files
authored
Create result entries even when no changes (#429)
The primary purpose of this change is to enable the collection of codemod descriptions even when no actual changes are present. It also aligns codemodder-java with the existing behavior of codemodder-python.
1 parent bf886d3 commit 964f558

File tree

2 files changed

+7
-5
lines changed
  • core-codemods/src/intTest/java/io/codemodder/integration
  • framework/codemodder-base/src/main/java/io/codemodder

2 files changed

+7
-5
lines changed

core-codemods/src/intTest/java/io/codemodder/integration/WebGoat822Test.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,11 @@ void it_injects_dependency_even_when_no_poms_included() throws Exception {
5252

5353
verifyNoFailedFiles(report);
5454
List<CodeTFResult> results = report.getResults();
55-
assertThat(results.size(), is(1));
56-
CodeTFResult result = results.get(0);
55+
CodeTFResult result =
56+
results.stream()
57+
.filter(r -> r.getCodemod().equals("pixee:java/harden-java-deserialization"))
58+
.findFirst()
59+
.orElseThrow();
5760
List<CodeTFChangesetEntry> changeset = result.getChangeset();
5861
assertThat(changeset.size(), is(3));
5962
assertThat(

framework/codemodder-base/src/main/java/io/codemodder/CLI.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,8 @@ public Integer call() throws IOException {
447447

448448
log.info("running codemod: {}", codemod.getId());
449449
CodeTFResult result = codemodExecutor.execute(filePaths);
450-
if (!result.getChangeset().isEmpty() || !result.getFailedFiles().isEmpty()) {
451-
results.add(result);
452-
}
450+
results.add(result);
451+
453452
if (!result.getChangeset().isEmpty()) {
454453
log.info("changed:");
455454
result

0 commit comments

Comments
 (0)