better bandaid

nahsra · nahsra · commit 9a6d378931d6 · 2024-02-29T10:27:44.000-05:00
diff --git a/gradle/build-plugins/src/main/kotlin/io.codemodder.maven-publish.gradle.kts b/gradle/build-plugins/src/main/kotlin/io.codemodder.maven-publish.gradle.kts
@@ -22,11 +22,12 @@ extensions.getByType<nebula.plugin.contacts.ContactsExtension>().run {
 
 val publicationName = "nebula"
 signing {
-    setRequired(false)
     if (providers.environmentVariable("CI").isPresent) {
         val signingKey: String? by project
         val signingPassword: String? by project
         useInMemoryPgpKeys(signingKey, signingPassword)
+    } else {
+        isRequired = false
     }
     sign(extensions.getByType<PublishingExtension>().publications.getByName(publicationName))
 }

Original file line number	Diff line number	Diff line change
`@@ -22,11 +22,12 @@ extensions.getByType<nebula.plugin.contacts.ContactsExtension>().run {`
`22`	`22`
`23`	`23`	`val publicationName = "nebula"`
`24`	`24`	`signing {`
`25`		`- setRequired(false)`
`26`	`25`	`if (providers.environmentVariable("CI").isPresent) {`
`27`	`26`	`val signingKey: String? by project`
`28`	`27`	`val signingPassword: String? by project`
`29`	`28`	`useInMemoryPgpKeys(signingKey, signingPassword)`
	`29`	`+ } else {`
	`30`	`+ isRequired = false`
`30`	`31`	`}`
`31`	`32`	`sign(extensions.getByType<PublishingExtension>().publications.getByName(publicationName))`
`32`	`33`	`}`