Fixed tests and refactoring

Author: andrecsilva

src/codemodder/codemods/test/integration_utils.py

@@ -293,7 +293,7 @@ def check_sonar_issues(cls):
         )
 
         assert any(
-            map(lambda x: x in sonar_results, cls.codemod.requested_rules)
+            [x in sonar_results for x in cls.codemod.requested_rules]
         ), f"Make sure to add a sonar issue/hotspot for {cls.codemod.rule_id} in {cls.sonar_issues_json} or {cls.sonar_hotspots_json}"
         results_for_codemod = sonar_results[cls.codemod.requested_rules[-1]]
         file_path = pathlib.Path(cls.code_filename)

src/codemodder/scripts/generate_docs.py

@@ -328,6 +328,12 @@ class DocMetadata:
         need_sarif="Yes (Sonar)",
     )
     for name in SONAR_CODEMOD_NAMES
+} | {
+    "secure-cookie": DocMetadata(
+        importance="Medium",
+        guidance_explained="Our change provides the most secure way to create cookies in Flask. However, it's possible you have configured your Flask application configurations to use secure cookies. In these cases, using the default parameters for `set_cookie` is safe.",
+        need_sarif="Yes (Sonar)",
+    ),
 }
 
 SEMGREP_CODEMOD_NAMES = [

src/core_codemods/sonar/sonar_secure_cookie.py

@@ -25,7 +25,6 @@ class SonarSecureCookieTransformer(LibcstResultTransformer, SecureCookieMixin):
     change_description = "Flask response `set_cookie` call should be called with `secure=True`, `httponly=True`, and `samesite='Lax'`."
 
     def leave_Call(self, original_node, updated_node):
-        # Try to match the func
         if self.node_is_selected(original_node.func):
             self.report_change(original_node)
             new_args = self.replace_args(

tests/test_sonar_results.py

@@ -43,7 +43,7 @@ def test_parse_issues_json():
 
 def test_parse_hotspots_json():
     results = SonarResultSet.from_json(SAMPLE_DIR / "sonar_hotspots.json")
-    assert len(results) == 2
+    assert len(results) == 4
 
 
 def test_combined_json(tmpdir):
@@ -54,7 +54,7 @@ def test_combined_json(tmpdir):
     )
 
     results = SonarResultSet.from_json(Path(tmpdir).joinpath("combined.json"))
-    assert len(results) == 36
+    assert len(results) == 38
 
 
 def test_empty_issues(tmpdir, caplog):