Skip to content

Commit 492dd78

Browse files
committed
Fixed rule_id being inserted into finding_id field
1 parent fb5529e commit 492dd78

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/codemodder/result.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def get_locations(self) -> Sequence[Sequence[Location]]:
113113

114114
@dataclass(frozen=True, kw_only=True)
115115
class SASTResult(Result):
116-
finding_id: str
116+
finding_id: str | None
117117

118118

119119
@dataclass(frozen=True, kw_only=True)
@@ -126,7 +126,7 @@ def from_sarif(
126126
cls, sarif_result: ResultModel, sarif_run: Run, truncate_rule_id: bool = False
127127
) -> Self:
128128
rule_id = cls.extract_rule_id(sarif_result, sarif_run, truncate_rule_id)
129-
finding_id = cls.extract_finding_id(sarif_result) or rule_id
129+
finding_id = cls.extract_finding_id(sarif_result)
130130
return cls(
131131
rule_id=rule_id,
132132
locations=cls.extract_locations(sarif_result, sarif_run),

0 commit comments

Comments
 (0)