Use proper finding IDs for sonar and semgrep SARIF (#956)

drdavella · web-flow · commit 84de1e4c57a8 · 2025-01-09T14:23:43.000Z
diff --git a/src/codemodder/result.py b/src/codemodder/result.py
@@ -105,6 +105,7 @@ def from_sarif(
         )
 
     @classmethod
+    @abstractmethod
     def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:
         raise NotImplementedError
 
diff --git a/src/core_codemods/sonar/results.py b/src/core_codemods/sonar/results.py
@@ -69,7 +69,7 @@ def from_result(cls, result: dict) -> Self:
             locations=locations,
             codeflows=all_flows,
             finding=Finding(
-                id=rule_id,
+                id=finding_id,
                 rule=Rule(
                     id=rule_id,
                     name=name,

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,7 @@ def from_sarif(`
`105`	`105`	`)`
`106`	`106`
`107`	`107`	`@classmethod`
	`108`	`+ @abstractmethod`
`108`	`109`	`def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:`
`109`	`110`	`raise NotImplementedError`
`110`	`111`