Hardening suggestions for codemodder-python / req-r-lines (#417)

pixeebot[bot] · web-flow · commit b5b2ccf73aa0 · 2024-03-27T13:37:11.000Z
Simplify Boolean Expressions Using `startswith` and `endswith`

Co-authored-by: pixeebot[bot] &lt;104101892+pixeebot[bot]@users.noreply.github.com&gt;
diff --git a/src/codemodder/project_analysis/file_parsers/requirements_txt_file_parser.py b/src/codemodder/project_analysis/file_parsers/requirements_txt_file_parser.py
@@ -48,5 +48,5 @@ def _clean_lines(self, lines: list[str]) -> set[str]:
         return set(
             line.split("#")[0].strip()
             for line in lines
-            if not (line.startswith("#") or line.startswith("-r "))
+            if not line.startswith(("#", "-r "))
         )

Original file line number	Diff line number	Diff line change
`@@ -48,5 +48,5 @@ def _clean_lines(self, lines: list[str]) -> set[str]:`
`48`	`48`	`return set(`
`49`	`49`	`line.split("#")[0].strip()`
`50`	`50`	`for line in lines`
`51`		`- if not (line.startswith("#") or line.startswith("-r "))`
	`51`	`+ if not line.startswith(("#", "-r "))`
`52`	`52`	`)`