Filtered duplicates from queried urls in test

Fixed incorrectly placed annotation in test

Removed annotation

Author: andrecsilva

integration_tests/test_codemod_urls.py

@@ -37,9 +37,15 @@ async def check_accessible_urls(urls):
 
 @pytest.mark.asyncio
 async def test_codemod_reference_urls():
-    urls = [
-        ref.url for codemod in registry.codemods for ref in codemod._metadata.references
-    ]
+    urls = list(
+        set(
+            [
+                ref.url
+                for codemod in registry.codemods
+                for ref in codemod._metadata.references
+            ]
+        )
+    )
     await check_accessible_urls(urls)
 
 

src/core_codemods/add_requests_timeouts.py

@@ -27,7 +27,7 @@ def on_result_found(self, original_node, updated_node):
             Reference(
                 url="https://docs.python-requests.org/en/master/user/quickstart/#timeouts"
             ),
-            Reference(url="https://cwe.mitre.org/data/definitions/1088.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/1088"),
         ],
     ),
     detector=SemgrepRuleDetector(

src/core_codemods/defectdojo/semgrep/avoid_insecure_deserialization.py

@@ -58,7 +58,7 @@ def leave_Call(
             ],
         ),
         references=[
-            Reference(url="https://cwe.mitre.org/data/definitions/502.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/502"),
         ],
     ),
     transformer=LibcstTransformerPipeline(

src/core_codemods/defectdojo/semgrep/django_secure_set_cookie.py

@@ -52,7 +52,7 @@ def leave_Call(self, original_node: cst.Call, updated_node: cst.Call) -> cst.Cal
             ],
         ),
         references=[
-            Reference(url="https://cwe.mitre.org/data/definitions/614.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/614"),
         ],
     ),
     transformer=LibcstTransformerPipeline(DjangoSecureSetCookieTransformer),

src/core_codemods/disable_graphql_introspection.py

@@ -128,10 +128,10 @@ def _is_introspection_rule_or_starred(
                 url="https://owasp.org/www-project-web-security-testing-guide/v42/4-Web_Application_Security_Testing/12-API_Testing/01-Testing_GraphQL#introspection-queries",
             ),
             Reference(
-                url="https://cwe.mitre.org/data/definitions/200.html",
+                url="https://cwe.mitre.org/data/definitions/200",
             ),
             Reference(
-                url="https://cwe.mitre.org/data/definitions/669.html",
+                url="https://cwe.mitre.org/data/definitions/669",
             ),
         ],
     ),

src/core_codemods/django_debug_flag_on.py

@@ -16,7 +16,7 @@ class DjangoDebugFlagOn(SimpleCodemod):
             Reference(
                 url="https://docs.djangoproject.com/en/4.2/ref/settings/#std-setting-DEBUG"
             ),
-            Reference(url="https://cwe.mitre.org/data/definitions/489.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/489"),
         ],
     )
     change_description = "Flip `Django` debug flag to off."

src/core_codemods/django_session_cookie_secure_off.py

@@ -16,7 +16,7 @@ class DjangoSessionCookieSecureOff(SimpleCodemod):
             Reference(
                 url="https://docs.djangoproject.com/en/4.2/ref/settings/#session-cookie-secure"
             ),
-            Reference(url="https://cwe.mitre.org/data/definitions/614.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/614"),
         ],
     )
     change_description = "Sets Django's `SESSION_COOKIE_SECURE` flag if off or missing."

src/core_codemods/file_resource_leak.py

@@ -73,8 +73,8 @@ def line_filter(x):
         summary="Automatically Close Resources",
         review_guidance=ReviewGuidance.MERGE_WITHOUT_REVIEW,
         references=[
-            Reference(url="https://cwe.mitre.org/data/definitions/404.html"),
-            Reference(url="https://cwe.mitre.org/data/definitions/772.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/404"),
+            Reference(url="https://cwe.mitre.org/data/definitions/772"),
         ],
     ),
     transformer=LibcstTransformerPipeline(FileResourceLeakTransformer),

src/core_codemods/flask_enable_csrf_protection.py

@@ -19,7 +19,7 @@ class FlaskEnableCSRFProtection(
         references=[
             Reference(url="https://owasp.org/www-community/attacks/csrf"),
             Reference(url="https://flask-wtf.readthedocs.io/en/1.2.x/csrf/"),
-            Reference(url="https://cwe.mitre.org/data/definitions/352.html"),
+            Reference(url="https://cwe.mitre.org/data/definitions/352"),
         ],
     )
 

src/core_codemods/harden_pickle_load.py

@@ -22,7 +22,7 @@ class HardenPickleLoad(SimpleCodemod, ImportModifierCodemod):
                 url="https://github.com/trailofbits/fickling",
             ),
             Reference(
-                url="https://cwe.mitre.org/data/definitions/502.html",
+                url="https://cwe.mitre.org/data/definitions/502",
             ),
         ],
     )