Skip to content

Commit f44a0f9

Browse files
committed
SarifResult class should not be abstract
1 parent 9c39777 commit f44a0f9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/codemodder/result.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class SASTResult(Result):
9696

9797

9898
@dataclass(frozen=True, kw_only=True)
99-
class SarifResult(SASTResult, ABCDataclass):
99+
class SarifResult(SASTResult):
100100
location_type: ClassVar[Type[SarifLocation]]
101101

102102
@classmethod
@@ -122,9 +122,9 @@ def from_sarif(
122122
)
123123

124124
@classmethod
125-
@abstractmethod
126-
def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:
127-
raise NotImplementedError
125+
def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str | None:
126+
del result, run, rule_id
127+
return None
128128

129129
@classmethod
130130
def extract_locations(cls, sarif_result) -> Sequence[Location]:

0 commit comments

Comments
 (0)