From 39992403e7aba9745f5d6484c96a07205fb42b9c Mon Sep 17 00:00:00 2001
From: Daniel D'Avella <dan.davella@pixee.ai>
Date: Tue, 17 Dec 2024 14:38:01 -0500
Subject: [PATCH] Use proper finding IDs for sonar and semgrep SARIF

---
 src/codemodder/result.py           | 1 +
 src/core_codemods/sonar/results.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/codemodder/result.py b/src/codemodder/result.py
index 69d86bba..a5aff86f 100644
--- a/src/codemodder/result.py
+++ b/src/codemodder/result.py
@@ -105,6 +105,7 @@ def from_sarif(
         )
 
     @classmethod
+    @abstractmethod
     def rule_url_from_id(cls, result: dict, run: dict, rule_id: str) -> str:
         raise NotImplementedError
 
diff --git a/src/core_codemods/sonar/results.py b/src/core_codemods/sonar/results.py
index d6f34811..dbbe122a 100644
--- a/src/core_codemods/sonar/results.py
+++ b/src/core_codemods/sonar/results.py
@@ -69,7 +69,7 @@ def from_result(cls, result: dict) -> Self:
             locations=locations,
             codeflows=all_flows,
             finding=Finding(
-                id=rule_id,
+                id=finding_id,
                 rule=Rule(
                     id=rule_id,
                     name=name,