fix(storage): align nullable error kind and migration rollbacks

Author: pixel365

internal/repository/check/execution.go

@@ -47,9 +47,9 @@ INSERT INTO pulse.check_executions (
 		details = data
 	}
 
-	var errKind string
+	var errKind *string
 	if result.ErrorKind != e2.ErrNone {
-		errKind = string(result.ErrorKind)
+		errKind = new(result.ErrorKind.String())
 	}
 
 	_, err := e.db.Exec(ctx, query,
@@ -62,7 +62,7 @@ INSERT INTO pulse.check_executions (
 		result.FinishedAt,
 		result.Duration.Microseconds(),
 		result.AttemptsTotal,
-		&errKind,
+		errKind,
 		result.ErrorMessage,
 		details,
 	)
@@ -281,7 +281,7 @@ WITH params AS (
       CROSS JOIN params p
       WHERE e.service_id = p.service_id
         AND e.check_id = p.check_id
-        AND e.observed_at <= b.bucket_end
+        AND e.observed_at < b.bucket_end
       ORDER BY e.observed_at DESC, e.id DESC
       LIMIT 1
   ) last_event ON TRUE

migrations/0004_check_executions.sql

@@ -39,7 +39,7 @@ EXECUTE FUNCTION pulse.delete_prohibited();
 -- +goose Down
 DROP TRIGGER IF EXISTS check_executions_prohibit_delete ON pulse.check_executions;
 DROP TRIGGER IF EXISTS check_executions_prohibit_update ON pulse.check_executions;
-DROP INDEX IF EXISTS check_executions_service_id_idx;
-DROP INDEX IF EXISTS check_executions_check_id_idx;
-DROP INDEX IF EXISTS check_executions_execution_id_uidx;
+DROP INDEX IF EXISTS pulse.check_executions_service_id_idx;
+DROP INDEX IF EXISTS pulse.check_executions_check_id_idx;
+DROP INDEX IF EXISTS pulse.check_executions_execution_id_uidx;
 DROP TABLE IF EXISTS pulse.check_executions;

migrations/0005_check_states.sql

@@ -34,6 +34,6 @@ EXECUTE FUNCTION pulse.delete_prohibited();
 
 -- +goose Down
 DROP TRIGGER IF EXISTS check_states_prohibit_delete ON pulse.check_states;
-DROP INDEX IF EXISTS check_states_service_id_idx;
-DROP INDEX IF EXISTS check_states_check_id_idx;
+DROP INDEX IF EXISTS pulse.check_states_service_id_idx;
+DROP INDEX IF EXISTS pulse.check_states_check_id_idx;
 DROP TABLE IF EXISTS pulse.check_states;

migrations/0006_check_state_events.sql

@@ -42,5 +42,5 @@ EXECUTE FUNCTION pulse.delete_prohibited();
 -- +goose Down
 DROP TRIGGER IF EXISTS check_state_events_prohibit_delete ON pulse.check_state_events;
 DROP TRIGGER IF EXISTS check_state_events_prohibit_update ON pulse.check_state_events;
-DROP INDEX IF EXISTS check_state_events_service_check_observed_id_idx;
+DROP INDEX IF EXISTS pulse.check_state_events_service_check_observed_id_idx;
 DROP TABLE IF EXISTS pulse.check_state_events;