Conflict between TwitchAdSolutions and Keep Tab Active

[sn-o-w]

Hi there,

I suspect vaft and video-swap-new may interfere with the following userscript:

https://github.com/Vikindor/twitch-keep-tab-active/raw/refs/heads/master/Twitch_-_Keep_Tab_Active.js

From what I can tell, when both scripts are enabled (either “vaft + Keep Tab Active” or “video-swap-new + Keep Tab Active”), they seem to clash. Both attempt to simulate player interaction and override properties such as document.visibilityState and document.hidden.

This likely results in overlapping behavior, since they are trying to manipulate similar parts of the page. When active at the same time, they may end up interfering with each other, reducing overall effectiveness or causing unintended side effects. 🤔

[pixeltris]

If you'd like to use their script you'll want to disable the following code:

TwitchAdSolutions/video-swap-new/video-swap-new.user.js

Lines 867 to 922 in 5a85380

	// This stops Twitch from pausing the player when in another tab and an ad shows.
	// Taken from https://github.com/saucettv/VideoAdBlockForTwitch/blob/cefce9d2b565769c77e3666ac8234c3acfe20d83/chrome/content.js#L30
	try {
	Object.defineProperty(document, 'visibilityState', {
	get() {
	return 'visible';
	}
	});
	}catch{}
	let hidden = document.__lookupGetter__('hidden');
	let webkitHidden = document.__lookupGetter__('webkitHidden');
	try {
	Object.defineProperty(document, 'hidden', {
	get() {
	return false;
	}
	});
	}catch{}
	const block = e => {
	e.preventDefault();
	e.stopPropagation();
	e.stopImmediatePropagation();
	};
	let wasVideoPlaying = true;
	const visibilityChange = e => {
	if (typeof chrome !== 'undefined') {
	const videos = document.getElementsByTagName('video');
	if (videos.length > 0) {
	if (hidden.apply(document) === true || (webkitHidden && webkitHidden.apply(document) === true)) {
	wasVideoPlaying = !videos[0].paused && !videos[0].ended;
	} else if (wasVideoPlaying && !videos[0].ended && videos[0].paused && videos[0].muted) {
	videos[0].play();
	}
	}
	}
	block(e);
	};
	document.addEventListener('visibilitychange', visibilityChange, true);
	document.addEventListener('webkitvisibilitychange', visibilityChange, true);
	document.addEventListener('mozvisibilitychange', visibilityChange, true);
	document.addEventListener('hasFocus', block, true);
	try {
	if (/Firefox/.test(navigator.userAgent)) {
	Object.defineProperty(document, 'mozHidden', {
	get() {
	return false;
	}
	});
	} else {
	Object.defineProperty(document, 'webkitHidden', {
	get() {
	return false;
	}
	});
	}
	}catch{}

This is something you'll need to do yourself. I wont be applying this to the main repo as it will cause issues for people who don't use that other script.

[sn-o-w]

This is something you'll need to do yourself. I wont be applying this to the main repo as it will cause issues for people who don't use that other script.

But that would imply that I have to manually modify the code at every update of your userscripts. 😶 This is not optimal... From what I've seen, you added support so that your userscripts do not interfere with TwitchNoSub. There must be a more elegant way to make your userscripts not interfere with Keep Tab Active, too. 🤔

[pixeltris]

But that would imply that I have to manually modify the code at every update of your userscripts. 😶 This is not optimal...

People fork code all the time. Nothing wrong with maintaining your own fork.

If you want to put in the effort you can investigate how to prevent the conflict in a similar way to the TwitchNoSub conflict and then create a PR.