Skip to content

Commit 4270147

Browse files
committed
Fix linting
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
1 parent af0447c commit 4270147

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

src/cloud/api/ptproxy/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,15 @@ go_library(
3232
"//src/cloud/shared/vzshard",
3333
"//src/shared/cvmsgspb:cvmsgs_pl_go_proto",
3434
"//src/shared/services/authcontext",
35-
"//src/shared/services/utils",
3635
"//src/shared/services/jwtpb:jwt_pl_go_proto",
36+
"//src/shared/services/utils",
3737
"//src/utils",
3838
"@com_github_gofrs_uuid//:uuid",
39-
"@com_github_spf13_viper//:viper",
4039
"@com_github_gogo_protobuf//proto",
4140
"@com_github_gogo_protobuf//types",
4241
"@com_github_nats_io_nats_go//:nats_go",
4342
"@com_github_sirupsen_logrus//:logrus",
43+
"@com_github_spf13_viper//:viper",
4444
"@org_golang_google_grpc//:grpc",
4545
"@org_golang_google_grpc//codes",
4646
"@org_golang_google_grpc//metadata",

src/cloud/api/ptproxy/vizier_pt_proxy.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ import (
3030
"google.golang.org/grpc/codes"
3131
"google.golang.org/grpc/metadata"
3232
"google.golang.org/grpc/status"
33-
jwtutils "px.dev/pixie/src/shared/services/utils"
3433

3534
"px.dev/pixie/src/api/proto/uuidpb"
3635
"px.dev/pixie/src/api/proto/vizierpb"
3736
"px.dev/pixie/src/cloud/scriptmgr/scriptmgrpb"
3837
"px.dev/pixie/src/shared/cvmsgspb"
3938
"px.dev/pixie/src/shared/services/authcontext"
4039
"px.dev/pixie/src/shared/services/jwtpb"
40+
jwtutils "px.dev/pixie/src/shared/services/utils"
4141
)
4242

4343
type vzmgrClient interface {
@@ -79,6 +79,10 @@ func (v *VizierPassThroughProxy) isScriptModified(ctx context.Context, script st
7979
ctx = metadata.AppendToOutgoingContext(ctx, "authorization",
8080
fmt.Sprintf("bearer %s", serviceAuthToken))
8181

82+
if err != nil {
83+
return false, err
84+
}
85+
8286
resp, err := v.sm.GetScriptByHash(ctx, req)
8387

8488
if err != nil {

src/cloud/api/ptproxy/vizier_pt_proxy_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,9 @@ func TestVizierPassThroughProxy_ExecuteScriptWithScriptModificationEnabled(t *te
398398
})
399399

400400
err = eg.Wait()
401+
if err != nil {
402+
t.Fatalf("Got error while streaming grpc: %v", err)
403+
}
401404
if tc.expGRPCError != nil {
402405
if gotReadErr == nil {
403406
t.Fatal("Expected to get GRPC error")

0 commit comments

Comments
 (0)