Skip to content

Commit 685ed42

Browse files
authored
Allow clang and gcc builds for src/e2e_test/vizier/planner:planner_test (#2077)
Summary: Allow clang and gcc builds for `src/e2e_test/vizier/planner:planner_test` As far as I can tell, there isn't a bazel config that matches the tags of the `src/e2e_test/vizier/planner:planner_test` target. This change removes the tag preventing clang builds since they appear to run without problems. In addition to this, a `vispb` proto change was missing from the earlier differential flamegraph work. This prevented the `planner_test` from running properly (see comment for more details). Relevant Issues: N/A Type of change: /kind bugfix Test Plan: Verified gcc and clang builds work - [x] `bazel test --config clang src/e2e_test/vizier/planner:planner_test` is successful - [x] `bazel test -c opt --config gcc src/e2e_test/vizier/planner:planner_test` is successful --------- Signed-off-by: Dom Del Nano <[email protected]>
1 parent e20880f commit 685ed42

File tree

6 files changed

+218
-126
lines changed

6 files changed

+218
-126
lines changed

src/api/proto/vispb/vis.pb.go

Lines changed: 180 additions & 123 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/api/proto/vispb/vis.proto

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -458,4 +458,7 @@ message StackTraceFlameGraph {
458458
string node_column = 8;
459459
// The label for the percentage.
460460
string percentage_label = 9;
461+
// The column containing the stacktrace's delta. This is only relevant for differential
462+
// flamegraphs.
463+
string difference_column = 10;
461464
}

src/common/exec/exec.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,14 @@
2424

2525
namespace px {
2626

27+
// GCC's ingnored-attribute warning is triggered without wrapping pclose. This is likely do to the
28+
// nonnull attribute.
29+
struct pclose_deleter {
30+
void operator()(FILE* file) const { pclose(file); }
31+
};
32+
2733
StatusOr<std::string> Exec(std::string cmd) {
28-
std::unique_ptr<FILE, decltype(&pclose)> pipe(popen(cmd.c_str(), "r"), pclose);
34+
std::unique_ptr<FILE, pclose_deleter> pipe(popen(cmd.c_str(), "r"));
2935
if (pipe == nullptr) {
3036
return error::Internal("popen() failed!");
3137
}

src/e2e_test/vizier/planner/BUILD.bazel

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ pl_go_test(
2424
],
2525
tags = [
2626
"no_asan",
27-
"no_gcc",
28-
"no_libcpp",
2927
"no_msan",
3028
"no_tsan",
3129
],

src/ui/src/types/generated/vis_pb.d.ts

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ui/src/types/generated/vis_pb.js

Lines changed: 22 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)