Skip to content

Commit a6349a9

Browse files
authored
Replace u8string method to keep return value consistent (#2308)
Summary: Replace `u8string` method to keep return value consistent In c++ 20, the `u8string` method uses a different return type. This PR removes the use of this function to keep the code compatible with c++17 and c++20 in preparation for the clang 21 upgrade. Relevant Issues: #2298 Type of change: /kind cleanup Test Plan: Build should succeed Signed-off-by: Dom Del Nano <[email protected]>
1 parent a4cdf70 commit a6349a9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/carnot/funcs/os/filesystem.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ inline std::string GetSharedLibraries(md::UPID upid) {
4242
for (const auto& p : std::filesystem::directory_iterator(fpath)) {
4343
if (std::filesystem::is_symlink(p)) {
4444
auto symlink = std::filesystem::read_symlink(p);
45-
libraries.push_back(symlink.u8string());
45+
libraries.push_back(symlink.string());
4646
}
4747
}
4848

0 commit comments

Comments
 (0)