Restore the state when OpenSLESRecorder::CreateAudioRecorder fails

OpenSLESRecorder will be inconsistent if CreateAudioRecorder fails.
For example, it is possible that recorder_object_ is set and
simple_buffer_queue_ is not set at the same time.
In that case, OpenSLESRecorder::DestroyAudioRecorder considers it audio
recorder is created, and tries to use simple_buffer_queue_ to reset the
state, which leads to segmentation fault.

Restore the state when OpenSLESRecorder::CreateAudioRecorder fails to
avoid such a complication.

Author: akihikodaki

modules/audio_device/android/opensles_recorder.cc

@@ -250,60 +250,73 @@ bool OpenSLESRecorder::CreateAudioRecorder() {
   const SLInterfaceID interface_id[] = {SL_IID_ANDROIDSIMPLEBUFFERQUEUE,
                                         SL_IID_ANDROIDCONFIGURATION};
   const SLboolean interface_required[] = {SL_BOOLEAN_TRUE, SL_BOOLEAN_TRUE};
+  SLAndroidConfigurationItf recorder_config;
+  SLint32 stream_type = SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION;
+
   if (LOG_ON_ERROR((*engine_)->CreateAudioRecorder(
           engine_, recorder_object_.Receive(), &audio_source, &audio_sink,
           arraysize(interface_id), interface_id, interface_required))) {
-    return false;
+    goto fail;
   }
 
   // Configure the audio recorder (before it is realized).
-  SLAndroidConfigurationItf recorder_config;
   if (LOG_ON_ERROR((recorder_object_->GetInterface(recorder_object_.Get(),
                                                    SL_IID_ANDROIDCONFIGURATION,
                                                    &recorder_config)))) {
-    return false;
+    goto fail_recorder_object;
   }
 
   // Uses the default microphone tuned for audio communication.
   // Note that, SL_ANDROID_RECORDING_PRESET_VOICE_RECOGNITION leads to a fast
   // track but also excludes usage of required effects like AEC, AGC and NS.
   // SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION
-  SLint32 stream_type = SL_ANDROID_RECORDING_PRESET_VOICE_COMMUNICATION;
   if (LOG_ON_ERROR(((*recorder_config)
                         ->SetConfiguration(recorder_config,
                                            SL_ANDROID_KEY_RECORDING_PRESET,
                                            &stream_type, sizeof(SLint32))))) {
-    return false;
+    goto fail_recorder_object;
   }
 
   // The audio recorder can now be realized (in synchronous mode).
   if (LOG_ON_ERROR((recorder_object_->Realize(recorder_object_.Get(),
                                               SL_BOOLEAN_FALSE)))) {
-    return false;
+    goto fail_recorder_object;
   }
 
   // Get the implicit recorder interface (SL_IID_RECORD).
   if (LOG_ON_ERROR((recorder_object_->GetInterface(
           recorder_object_.Get(), SL_IID_RECORD, &recorder_)))) {
-    return false;
+    goto fail_recorder_object;
   }
 
   // Get the simple buffer queue interface (SL_IID_ANDROIDSIMPLEBUFFERQUEUE).
   // It was explicitly requested.
   if (LOG_ON_ERROR((recorder_object_->GetInterface(
           recorder_object_.Get(), SL_IID_ANDROIDSIMPLEBUFFERQUEUE,
           &simple_buffer_queue_)))) {
-    return false;
+    goto fail_recorder;
   }
 
   // Register the input callback for the simple buffer queue.
   // This callback will be called when receiving new data from the device.
   if (LOG_ON_ERROR(((*simple_buffer_queue_)
                         ->RegisterCallback(simple_buffer_queue_,
                                            SimpleBufferQueueCallback, this)))) {
-    return false;
+    goto fail_simple_buffer_queue;
   }
   return true;
+
+fail_simple_buffer_queue:
+  simple_buffer_queue_ = nullptr;
+
+fail_recorder:
+  recorder_ = nullptr;
+
+fail_recorder_object:
+  recorder_object_.Reset();
+
+fail:
+  return false;
 }
 
 void OpenSLESRecorder::DestroyAudioRecorder() {