Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Commit ad73985

Browse files
committed
Add implemented-but-missing members to RTCMediaStreamTrackStats::Members
silentConcealedSamples, insertedSamplesForDeceleration and removedSamplesForAcceleration were implemented in M76, but we forgot to add them to the WEBRTC_RTCSTATS_IMPL list, meaning the "iterate all members" method, RTCStats::Members(), did not contain these metrics. As a consequence, Chrome did not pick up these members for exposure to JavaScript. Also fix the test coverage in rtc_stats_integrationtest.cc where code paths that did not apply to audio track stats were not explicitly asserting that they must be undefined in those cases. (cherry picked from commit 21e99da) Bug: chromium:996146, webrtc:10903 Change-Id: I00e7ddee600818ee4d561b88e005391830adcf3e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149816 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#28925} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150322 Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/branch-heads/m77@{#10} Cr-Branched-From: 2bac7da-refs/heads/master@{#28685}
1 parent 6e1055b commit ad73985

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

pc/rtc_stats_integrationtest.cc

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -629,7 +629,13 @@ class RTCStatsReportVerifier {
629629
verifier.TestMemberIsUndefined(media_stream_track.total_samples_duration);
630630
verifier.TestMemberIsUndefined(media_stream_track.total_samples_received);
631631
verifier.TestMemberIsUndefined(media_stream_track.concealed_samples);
632+
verifier.TestMemberIsUndefined(
633+
media_stream_track.silent_concealed_samples);
632634
verifier.TestMemberIsUndefined(media_stream_track.concealment_events);
635+
verifier.TestMemberIsUndefined(
636+
media_stream_track.inserted_samples_for_deceleration);
637+
verifier.TestMemberIsUndefined(
638+
media_stream_track.removed_samples_for_acceleration);
633639
verifier.TestMemberIsUndefined(media_stream_track.jitter_buffer_flushes);
634640
verifier.TestMemberIsUndefined(
635641
media_stream_track.delayed_packet_outage_samples);
@@ -657,14 +663,14 @@ class RTCStatsReportVerifier {
657663
media_stream_track.total_samples_duration);
658664
verifier.TestMemberIsNonNegative<uint64_t>(
659665
media_stream_track.concealed_samples);
666+
verifier.TestMemberIsNonNegative<uint64_t>(
667+
media_stream_track.silent_concealed_samples);
660668
verifier.TestMemberIsNonNegative<uint64_t>(
661669
media_stream_track.concealment_events);
662670
verifier.TestMemberIsNonNegative<uint64_t>(
663671
media_stream_track.inserted_samples_for_deceleration);
664672
verifier.TestMemberIsNonNegative<uint64_t>(
665673
media_stream_track.removed_samples_for_acceleration);
666-
verifier.TestMemberIsNonNegative<uint64_t>(
667-
media_stream_track.silent_concealed_samples);
668674
verifier.TestMemberIsNonNegative<uint64_t>(
669675
media_stream_track.jitter_buffer_flushes);
670676
verifier.TestMemberIsNonNegative<uint64_t>(
@@ -689,7 +695,13 @@ class RTCStatsReportVerifier {
689695
verifier.TestMemberIsUndefined(
690696
media_stream_track.total_samples_duration);
691697
verifier.TestMemberIsUndefined(media_stream_track.concealed_samples);
698+
verifier.TestMemberIsUndefined(
699+
media_stream_track.silent_concealed_samples);
692700
verifier.TestMemberIsUndefined(media_stream_track.concealment_events);
701+
verifier.TestMemberIsUndefined(
702+
media_stream_track.inserted_samples_for_deceleration);
703+
verifier.TestMemberIsUndefined(
704+
media_stream_track.removed_samples_for_acceleration);
693705
verifier.TestMemberIsUndefined(
694706
media_stream_track.jitter_buffer_flushes);
695707
verifier.TestMemberIsUndefined(

stats/rtcstats_objects.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,10 @@ WEBRTC_RTCSTATS_IMPL(RTCMediaStreamTrackStats, RTCStats, "track",
391391
&total_samples_received,
392392
&total_samples_duration,
393393
&concealed_samples,
394+
&silent_concealed_samples,
394395
&concealment_events,
396+
&inserted_samples_for_deceleration,
397+
&removed_samples_for_acceleration,
395398
&jitter_buffer_flushes,
396399
&delayed_packet_outage_samples,
397400
&relative_packet_arrival_delay,

0 commit comments

Comments
 (0)