Skip to content

Commit 6415315

Browse files
committed
PRESIDECMS-3000 do not output fa-fw icon when there is no icon
set for a tab.
1 parent cfe47fc commit 6415315

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

system/base/EnhancedDataManagerBase.cfc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ component extends="preside.system.base.AdminHandler" {
319319

320320
args.tabs[ i ] = {
321321
id = tabId
322-
, iconClass = translateResource( uri=i18nBase & "viewtab.#tabId#.iconclass", defaultValue=translateResource( i18nDefaultBase & "viewtab.#tabId#.iconclass" ) )
322+
, iconClass = translateResource( uri=i18nBase & "viewtab.#tabId#.iconclass", defaultValue=translateResource( uri=i18nDefaultBase & "viewtab.#tabId#.iconclass", defaultValue="" ) )
323323
, content = customizationService.runCustomization( objectName=objectName, action="_#tabId#Tab", args=args )
324324
, title = customizationService.runCustomization( objectName=objectName, action="_#tabId#TabTitle", args=args, defaultResult=translateResource( uri=i18nBase & "viewtab.#tabId#.title", defaultValue=translateResource( i18nDefaultBase & "viewtab.#tabId#.title" ) ) )
325325
};

system/views/admin/datamanager/_tabs.cfm

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@
2828
</cfif>
2929
<li<cfif tab.id eq activeTab> class="active"</cfif>>
3030
<a href="##tab-#tab.id#" data-toggle="tab" >
31-
<i class="fa fa-fw #tab.iconClass#" title="#HtmlEditFormat( tab.title )#"></i>&nbsp;
31+
<cfif Len( tab.iconClass )>
32+
<i class="fa fa-fw #tab.iconClass#" title="#HtmlEditFormat( tab.title )#"></i>&nbsp;
33+
</cfif>
3234

3335
<span class="hidden-xs">
3436
#tab.title#

0 commit comments

Comments
 (0)