Skip to content

Commit f792c6c

Browse files
committed
DATAAPI-46: skip queue flag evaluation
1 parent 6f45391 commit f792c6c

File tree

1 file changed

+16
-24
lines changed

1 file changed

+16
-24
lines changed

interceptors/DataApiInterceptors.cfc

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ component extends="coldbox.system.Interceptor" {
118118
}
119119

120120
public void function preDeleteObjectData( event, interceptData ) {
121-
if ( !_applicationLoaded ) return;
121+
if ( _skipQueue( interceptData ) ) return;
122122

123123
if( isEmptyString( interceptData.id ?: "" ) ){
124124
interceptData.deletedIds = dataApiQueueService.getDeletedRecordIds( argumentCollection = interceptData );
@@ -142,49 +142,41 @@ component extends="coldbox.system.Interceptor" {
142142
}
143143

144144
public void function postDeleteObjectData( event, interceptData ) {
145-
if ( !_applicationLoaded ) return;
146-
147-
var skipDataApiQueue = IsBoolean( interceptData.skipDataApiQueue ?: "" ) && interceptData.skipDataApiQueue;
148-
var skipSyncQueue = IsBoolean( interceptData.skipSyncQueue ?: "" ) && interceptData.skipSyncQueue;
149-
150-
skipDataApiQueue = skipDataApiQueue || ( skipSyncQueue && dataApiConfigurationService.skipApiQueueWhenSkipSyncQueue( interceptData.objectName ) );
151-
152-
if( skipDataApiQueue ) return;
145+
if ( _skipQueue( interceptData ) ) return;
153146

154147
dataApiQueueService.queueDelete( argumentCollection=interceptData );
155148
}
156149

157150
public void function preUpdateObjectData( event, interceptData ) {
158-
if ( !_applicationLoaded ) return;
151+
if ( _skipQueue( interceptData ) ) return;
159152

160153
if ( dataApiQueueService.queueRequired( argumentCollection=interceptData ) ) {
161154
interceptData.calculateChangedData = true;
162155
}
163156
}
164157

165158
public void function postUpdateObjectData( event, interceptData ) {
166-
if ( !_applicationLoaded ) return;
167-
168-
var skipDataApiQueue = IsBoolean( interceptData.skipDataApiQueue ?: "" ) && interceptData.skipDataApiQueue;
169-
var skipSyncQueue = IsBoolean( interceptData.skipSyncQueue ?: "" ) && interceptData.skipSyncQueue;
170-
171-
skipDataApiQueue = skipDataApiQueue || ( skipSyncQueue && dataApiConfigurationService.skipApiQueueWhenSkipSyncQueue( interceptData.objectName ) );
172-
173-
if( skipDataApiQueue ) return;
159+
if ( _skipQueue( interceptData ) ) return;
174160

175161
dataApiQueueService.queueUpdate( argumentCollection=interceptData );
176162
}
177163

178164
public void function postInsertObjectData( event, interceptData ) {
179-
if ( !_applicationLoaded ) return;
165+
if ( _skipQueue( interceptData ) ) return;
166+
167+
dataApiQueueService.queueInsert( argumentCollection=interceptData );
168+
}
180169

181-
var skipDataApiQueue = IsBoolean( interceptData.skipDataApiQueue ?: "" ) && interceptData.skipDataApiQueue;
182-
var skipSyncQueue = IsBoolean( interceptData.skipSyncQueue ?: "" ) && interceptData.skipSyncQueue;
170+
private boolean function _skipQueue( interceptData ) {
183171

184-
skipDataApiQueue = skipDataApiQueue || ( skipSyncQueue && dataApiConfigurationService.skipApiQueueWhenSkipSyncQueue( interceptData.objectName ) );
172+
if ( !_applicationLoaded ) {
173+
return true;
174+
}
185175

186-
if( skipDataApiQueue ) return;
176+
if ( IsTrue( interceptData.skipDataApiQueue ?: "" ) ) {
177+
return true;
178+
}
187179

188-
dataApiQueueService.queueInsert( argumentCollection=interceptData );
180+
return IsTrue( interceptData.skipSyncQueue ?: "" ) && dataApiConfigurationService.skipApiQueueWhenSkipSyncQueue( interceptData.objectName );
189181
}
190182
}

0 commit comments

Comments
 (0)