update subcategory tests and add duplicate link test

Author: piyush-jaiswal

tests/conftest.py

@@ -73,7 +73,7 @@ def _create(name, categories=None, products=None, headers=None):
             payload["categories"] = categories
         if products is not None:
             payload["products"] = products
-        return client.post("/subcategory/create", json=payload, headers=headers)
+        return client.post("/subcategories", json=payload, headers=headers)
 
     return _create
 

tests/test_relationships.py

@@ -112,23 +112,58 @@ def test_update_category_adds_linked_subcategories(self, create_authenticated_he
         assert self._category_subcategory_ids(category["id"]) == [subcategory["id"]]
 
     def test_update_subcategory_adds_categories_and_products(self, create_authenticated_headers, create_category, create_product, create_subcategory):
-        category1 = create_category("UC1").get_json()
-        category2 = create_category("UC2").get_json()
-        product1 = create_product("UP1").get_json()
-        product2 = create_product("UP2").get_json()
-        subcategory = create_subcategory("U_SC").get_json()
-
         headers = create_authenticated_headers()
+        category1 = create_category("UC1", headers=headers).get_json()
+        category2 = create_category("UC2", headers=headers).get_json()
+        product1 = create_product("UP1", headers=headers).get_json()
+        product2 = create_product("UP2", headers=headers).get_json()
+        subcategory = create_subcategory("U_SC", headers=headers).get_json()
+
         update_response = self.client.put(
-            f"/subcategory/{subcategory['id']}/update",
+            f"/subcategories/{subcategory['id']}",
             json={"categories": [category1["id"], category2["id"]], "products": [product1["id"], product2["id"]]},
             headers=headers,
         )
-        assert update_response.status_code == 201
+        assert update_response.status_code == 200
 
         assert self._subcategory_category_ids(subcategory["id"]) == sorted([category1["id"], category2["id"]])
         assert self._subcategory_product_ids(subcategory["id"]) == sorted([product1["id"], product2["id"]])
 
+    def test_update_subcategory_adds_linked_categories_and_products(self, create_authenticated_headers, create_category, create_product, create_subcategory):
+        headers = create_authenticated_headers()
+        category = create_category("UC1", headers=headers).get_json()
+        product = create_product("UP1", headers=headers).get_json()
+        subcategory = create_subcategory("U_SC", categories=[category["id"]], products=[product["id"]], headers=headers).get_json()
+
+        with pytest.raises(IntegrityError) as ie_c:
+            self.client.put(
+                f"/subcategories/{subcategory['id']}",
+                json={"categories": [category["id"]]},
+                headers=headers,
+            )
+        with pytest.raises(IntegrityError) as ie_p:
+            self.client.put(
+                f"/subcategories/{subcategory['id']}",
+                json={"products": [product["id"]]},
+                headers=headers,
+            )
+        with pytest.raises(IntegrityError) as ie_cp:
+            self.client.put(
+                f"/subcategories/{subcategory['id']}",
+                json={"categories": [category["id"]], "products": [product["id"]]},
+                headers=headers,
+            )
+
+        assert isinstance(ie_c.value.orig, sqlite3.IntegrityError)
+        assert isinstance(ie_p.value.orig, sqlite3.IntegrityError)
+        assert isinstance(ie_cp.value.orig, sqlite3.IntegrityError)
+        assert "UNIQUE constraint failed" in str(ie_c.value.orig)
+        assert "UNIQUE constraint failed" in str(ie_p.value.orig)
+        assert "UNIQUE constraint failed" in str(ie_cp.value.orig)
+
+        assert self._subcategory_category_ids(subcategory["id"]) == [category["id"]]
+        assert self._subcategory_product_ids(subcategory["id"]) == [product["id"]]
+
     def test_update_product_adds_subcategories(self, create_authenticated_headers, create_product, create_subcategory):
         subcategory1 = create_subcategory("UPS1").get_json()
         subcategory2 = create_subcategory("UPS2").get_json()
@@ -177,32 +212,34 @@ def test_get_category_products_populated_with_pagination(self, create_category,
 
     def test_get_subcategory_categories_empty(self, create_subcategory):
         subcategory = create_subcategory("SC_NoCat").get_json()
-        resp = self.client.get(f"/subcategory/{subcategory['id']}/categories")
+        resp = self.client.get(f"/subcategories/{subcategory['id']}/categories")
         self._assert_related_collection(resp, "categories")
 
-    def test_get_subcategory_categories_populated(self, create_category, create_subcategory):
-        category1 = create_category("C1").get_json()
-        category2 = create_category("C2").get_json()
-        subcategory = create_subcategory("SC_Cats", categories=[category1["id"], category2["id"]]).get_json()
+    def test_get_subcategory_categories_populated(self, create_category, create_subcategory, create_authenticated_headers):
+        headers = create_authenticated_headers()
+        category1 = create_category("C1", headers=headers).get_json()
+        category2 = create_category("C2", headers=headers).get_json()
+        subcategory = create_subcategory("SC_Cats", categories=[category1["id"], category2["id"]], headers=headers).get_json()
 
-        resp = self.client.get(f"/subcategory/{subcategory['id']}/categories")
+        resp = self.client.get(f"/subcategories/{subcategory['id']}/categories")
         self._assert_related_collection(resp, "categories", expected_ids=[category1["id"], category2["id"]])
 
     def test_get_subcategory_products_empty(self, create_subcategory):
         subcategory = create_subcategory("SC_NoProd").get_json()
-        resp = self.client.get(f"/subcategory/{subcategory['id']}/products")
+        resp = self.client.get(f"/subcategories/{subcategory['id']}/products")
         self._assert_related_collection(resp, "products")
 
-    def test_get_subcategory_products_populated_with_pagination(self, create_subcategory, create_product):
-        subcategory = create_subcategory("SC_Pag").get_json()
+    def test_get_subcategory_products_populated_with_pagination(self, create_subcategory, create_product, create_authenticated_headers):
+        headers = create_authenticated_headers()
+        subcategory = create_subcategory("SC_Pag", headers=headers).get_json()
 
         product_ids = set()
         for index in range(11):
-            product_resp = create_product(f"SP{index}", "desc", subcategories=[subcategory["id"]])
+            product_resp = create_product(f"SP{index}", "desc", subcategories=[subcategory["id"]], headers=headers)
             product_ids.add(product_resp.get_json().get("id"))
 
-        page1 = self.client.get(f"/subcategory/{subcategory['id']}/products?page=1").get_json()
-        page2 = self.client.get(f"/subcategory/{subcategory['id']}/products?page=2").get_json()
+        page1 = self.client.get(f"/subcategories/{subcategory['id']}/products?page=1").get_json()
+        page2 = self.client.get(f"/subcategories/{subcategory['id']}/products?page=2").get_json()
         assert len(page1["products"]) == 10
         assert len(page2["products"]) == 1
 
@@ -227,8 +264,8 @@ def test_get_product_subcategories_populated(self, create_product, create_subcat
         [
             "/categories/999999/subcategories",
             "/categories/999999/products",
-            "/subcategory/999999/categories",
-            "/subcategory/999999/products",
+            "/subcategories/999999/categories",
+            "/subcategories/999999/products",
             "/product/999999/subcategories",
         ],
     )

tests/test_subcategory.py

@@ -1,4 +1,7 @@
+import sqlite3
+
 import pytest
+from sqlalchemy.exc import IntegrityError
 
 from app.models import Subcategory
 from tests import utils
@@ -36,28 +39,33 @@ def test_create_subcategory(self, create_subcategory):
         assert "id" in data
         self._verify_subcategory_in_db(self.TEST_SUBCATEGORY_NAME)
 
-    def test_create_subcategory_duplicate_name(self, create_subcategory):
-        create_subcategory(self.TEST_SUBCATEGORY_NAME)
-        response = create_subcategory(self.TEST_SUBCATEGORY_NAME)
+    def test_create_subcategory_duplicate_name(self, create_subcategory, create_authenticated_headers):
+        headers = create_authenticated_headers()
+        create_subcategory(self.TEST_SUBCATEGORY_NAME, headers=headers)
 
-        assert response.status_code == 500
+        with pytest.raises(IntegrityError) as ie:
+            create_subcategory(self.TEST_SUBCATEGORY_NAME, headers=headers)
+
+        assert isinstance(ie.value.orig, sqlite3.IntegrityError)
+        assert "UNIQUE constraint failed" in str(ie.value.orig)
         assert self._count_subcategories() == 1
         self._verify_subcategory_in_db(self.TEST_SUBCATEGORY_NAME)
 
     def test_get_subcategory_by_id(self, create_subcategory):
         response = create_subcategory("Laptops")
         data = response.get_json()
         sc_id = data["id"]
-        get_resp = self.client.get(f"/subcategory/{sc_id}")
+        get_resp = self.client.get(f"/subcategories/{sc_id}")
 
         assert get_resp.status_code == 200
         data = get_resp.get_json()
         assert data["name"] == "Laptops"
         assert data["id"] == sc_id
 
-    def test_get_all_subcategories(self, create_subcategory):
-        create_subcategory("A")
-        create_subcategory("B")
+    def test_get_all_subcategories(self, create_subcategory, create_authenticated_headers):
+        headers = create_authenticated_headers()
+        create_subcategory("A", headers=headers)
+        create_subcategory("B", headers=headers)
         resp = self.client.get("/subcategories")
 
         assert resp.status_code == 200
@@ -74,10 +82,10 @@ def test_update_subcategory(self, create_authenticated_headers, create_subcatego
         data = response.get_json()
         sc_id = data["id"]
         update_resp = self.client.put(
-            f"/subcategory/{sc_id}/update", json={"name": "NewSubcat"}, headers=headers
+            f"/subcategories/{sc_id}", json={"name": "NewSubcat"}, headers=headers
         )
 
-        assert update_resp.status_code == 201
+        assert update_resp.status_code == 200
         data = update_resp.get_json()
         assert data["name"] == "NewSubcat"
         assert data["id"] == sc_id
@@ -89,10 +97,10 @@ def test_delete_subcategory(self, create_authenticated_headers, create_subcatego
         response = create_subcategory("ToDelete", headers=headers)
         data = response.get_json()
         sc_id = data["id"]
-        delete_resp = self.client.delete(f"/subcategory/{sc_id}", headers=headers)
+        delete_resp = self.client.delete(f"/subcategories/{sc_id}", headers=headers)
 
-        assert delete_resp.status_code == 200
-        get_resp = self.client.get(f"/subcategory/{sc_id}")
+        assert delete_resp.status_code == 204
+        get_resp = self.client.get(f"/subcategories/{sc_id}")
         assert get_resp.status_code == 404
         self._verify_subcategory_in_db("ToDelete", should_exist=False)
 
@@ -107,7 +115,7 @@ def test_delete_subcategory(self, create_authenticated_headers, create_subcatego
     def test_create_subcategory_token_error(self, get_headers, expected_code):
         headers = get_headers(self)
         response = self.client.post(
-            "/subcategory/create", json={"name": "CreateTokenError"}, headers=headers
+            "/subcategories", json={"name": "CreateTokenError"}, headers=headers
         )
         utils.verify_token_error_response(response, expected_code)
         self._verify_subcategory_in_db("CreateTokenError", should_exist=False)
@@ -128,7 +136,7 @@ def test_update_subcategory_token_error(self, get_headers, create_subcategory, c
 
         update_headers = get_headers(self)
         update_resp = self.client.put(
-            f"/subcategory/{sc_id}/update",
+            f"/subcategories/{sc_id}",
             json={"name": "UpdatedName"},
             headers=update_headers,
         )
@@ -152,7 +160,7 @@ def test_delete_subcategory_token_error(self, get_headers, create_subcategory, c
         sc_id = data["id"]
 
         delete_headers = get_headers(self)
-        delete_resp = self.client.delete(f"/subcategory/{sc_id}", headers=delete_headers)
+        delete_resp = self.client.delete(f"/subcategories/{sc_id}", headers=delete_headers)
 
         utils.verify_token_error_response(delete_resp, expected_code)
         self._verify_subcategory_in_db("DeleteTokenError")