Merge pull request #10 from piyush-jaiswal/feature/add-subcategory-tests

Add subcategory tests

Author: piyush-jaiswal

tests/conftest.py

@@ -7,6 +7,8 @@
 os.environ["JWT_SECRET_KEY"] = os.urandom(24).hex()
 
 from app import app, db
+from tests import utils
+
 
 
 @pytest.fixture
@@ -36,3 +38,14 @@ def _login(email, password):
         return client.post("/auth/login", json={"email": email, "password": password})
 
     return _login
+
+
+@pytest.fixture
+def create_authenticated_headers(register_user, login_user):
+    def _get_headers(email="[email protected]", password="testpassword"):
+        register_user(email, password)
+        resp = login_user(email, password)
+        tokens = resp.get_json()
+        return utils.get_auth_header(tokens["access_token"])
+
+    return _get_headers

tests/test_category.py

@@ -13,16 +13,6 @@ def setup(self, client):
         with client.application.app_context():
             assert Category.query.count() == 0
 
-    @pytest.fixture
-    def create_authenticated_headers(self, register_user, login_user):
-        def _get_headers(email="[email protected]", password="testpassword"):
-            register_user(email, password)
-            resp = login_user(email, password)
-            tokens = resp.get_json()
-            return utils.get_auth_header(tokens["access_token"])
-
-        return _get_headers
-
     @pytest.fixture
     def create_category(self, create_authenticated_headers):
         def _create(name, headers=None):
@@ -118,124 +108,63 @@ def test_delete_category(self, create_authenticated_headers, create_category):
         assert get_resp.status_code == 404
         self._verify_category_in_db("ToDelete", should_exist=False)
 
-    def test_create_category_expired_token(self):
-        headers = utils.get_expired_token_headers(self.client.application.app_context())
+    @pytest.mark.parametrize(
+        "get_headers, expected_code",
+        [
+            (lambda self: utils.get_expired_token_headers(self.client.application.app_context()), "token_expired"),
+            (lambda self: utils.get_invalid_token_headers(), "invalid_token"),
+            (lambda self: None, "authorization_required")
+        ]
+    )
+    def test_create_category_token_error(self, get_headers, expected_code):
+        headers = get_headers(self)
         response = self.client.post(
-            "/category/create", json={"name": "TestExpired"}, headers=headers
-        )
-
-        utils.verify_token_error_response(response, "token_expired")
-        self._verify_category_in_db("TestExpired", should_exist=False)
-
-    def test_create_category_invalid_token(self):
-        headers = utils.get_invalid_token_headers()
-        response = self.client.post(
-            "/category/create", json={"name": "TestInvalid"}, headers=headers
-        )
-
-        utils.verify_token_error_response(response, "invalid_token")
-        self._verify_category_in_db("TestInvalid", should_exist=False)
-
-    def test_create_category_missing_token(self):
-        response = self.client.post("/category/create", json={"name": "TestMissing"})
-        utils.verify_token_error_response(response, "authorization_required")
-        self._verify_category_in_db("TestMissing", should_exist=False)
-
-    def test_update_category_expired_token(
-        self, create_category, create_authenticated_headers
-    ):
-        headers = create_authenticated_headers()
-        response = create_category("UpdateExpired", headers)
-        data = response.get_json()
-        cat_id = data["id"]
-
-        expired_headers = utils.get_expired_token_headers(
-            self.client.application.app_context()
+            "/category/create", json={"name": "CreateTokenError"}, headers=headers
         )
-        update_resp = self.client.put(
-            f"/category/{cat_id}/update",
-            json={"name": "UpdatedName"},
-            headers=expired_headers,
-        )
-
-        utils.verify_token_error_response(update_resp, "token_expired")
-        self._verify_category_in_db("UpdateExpired")
-        self._verify_category_in_db("UpdatedName", should_exist=False)
-
-    def test_update_category_invalid_token(
-        self, create_category, create_authenticated_headers
-    ):
+        utils.verify_token_error_response(response, expected_code)
+        self._verify_category_in_db("CreateTokenError", should_exist=False)
+
+    @pytest.mark.parametrize(
+        "get_headers, expected_code",
+        [
+            (lambda self: utils.get_expired_token_headers(self.client.application.app_context()), "token_expired"),
+            (lambda self: utils.get_invalid_token_headers(), "invalid_token"),
+            (lambda self: None, "authorization_required")
+        ]
+    )
+    def test_update_category_token_error(self, get_headers, create_category, create_authenticated_headers, expected_code):
         headers = create_authenticated_headers()
-        response = create_category("UpdateInvalid", headers)
+        response = create_category("UpdateTokenError", headers)
         data = response.get_json()
         cat_id = data["id"]
 
-        invalid_headers = utils.get_invalid_token_headers()
+        update_headers = get_headers(self)
         update_resp = self.client.put(
             f"/category/{cat_id}/update",
             json={"name": "UpdatedName"},
-            headers=invalid_headers,
+            headers=update_headers,
         )
 
-        utils.verify_token_error_response(update_resp, "invalid_token")
-        self._verify_category_in_db("UpdateInvalid")
+        utils.verify_token_error_response(update_resp, expected_code)
+        self._verify_category_in_db("UpdateTokenError")
         self._verify_category_in_db("UpdatedName", should_exist=False)
 
-    def test_update_category_missing_token(
-        self, create_category, create_authenticated_headers
-    ):
-        headers = create_authenticated_headers()
-        response = create_category("UpdateMissing", headers)
-        data = response.get_json()
-        cat_id = data["id"]
-
-        update_resp = self.client.put(
-            f"/category/{cat_id}/update", json={"name": "UpdatedName"}
-        )
-
-        utils.verify_token_error_response(update_resp, "authorization_required")
-        self._verify_category_in_db("UpdateMissing")
-        self._verify_category_in_db("UpdatedName", should_exist=False)
-
-    def test_delete_category_expired_token(
-        self, create_category, create_authenticated_headers
-    ):
-        headers = create_authenticated_headers()
-        response = create_category("DeleteExpired", headers)
-        data = response.get_json()
-        cat_id = data["id"]
-
-        expired_headers = utils.get_expired_token_headers(
-            self.client.application.app_context()
-        )
-        delete_resp = self.client.delete(f"/category/{cat_id}", headers=expired_headers)
-
-        utils.verify_token_error_response(delete_resp, "token_expired")
-        self._verify_category_in_db("DeleteExpired")
-
-    def test_delete_category_invalid_token(
-        self, create_category, create_authenticated_headers
-    ):
-        headers = create_authenticated_headers()
-        response = create_category("DeleteInvalid", headers)
-        data = response.get_json()
-        cat_id = data["id"]
-
-        invalid_headers = utils.get_invalid_token_headers()
-        delete_resp = self.client.delete(f"/category/{cat_id}", headers=invalid_headers)
-
-        utils.verify_token_error_response(delete_resp, "invalid_token")
-        self._verify_category_in_db("DeleteInvalid")
-
-    def test_delete_category_missing_token(
-        self, create_category, create_authenticated_headers
-    ):
+    @pytest.mark.parametrize(
+        "get_headers, expected_code",
+        [
+            (lambda self: utils.get_expired_token_headers(self.client.application.app_context()), "token_expired"),
+            (lambda self: utils.get_invalid_token_headers(), "invalid_token"),
+            (lambda self: None, "authorization_required")
+        ]
+    )
+    def test_delete_category_token_error(self, get_headers, create_category, create_authenticated_headers, expected_code):
         headers = create_authenticated_headers()
-        response = create_category("DeleteMissing", headers)
+        response = create_category("DeleteTokenError", headers)
         data = response.get_json()
         cat_id = data["id"]
 
-        delete_resp = self.client.delete(f"/category/{cat_id}")
+        delete_headers = get_headers(self)
+        delete_resp = self.client.delete(f"/category/{cat_id}", headers=delete_headers)
 
-        utils.verify_token_error_response(delete_resp, "authorization_required")
-        self._verify_category_in_db("DeleteMissing")
+        utils.verify_token_error_response(delete_resp, expected_code)
+        self._verify_category_in_db("DeleteTokenError")