Skip to content

Commit 686bfcc

Browse files
no need to pass headers when creating resources
1 parent 874f625 commit 686bfcc

File tree

3 files changed

+30
-18
lines changed

3 files changed

+30
-18
lines changed

tests/test_category.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,14 @@ def test_get_all_categories(self, create_category):
7575
assert "B" in names
7676

7777
def test_update_category(self, create_authenticated_headers, create_category):
78-
headers = create_authenticated_headers()
79-
response = create_category("OldName", headers=headers)
78+
response = create_category("OldName")
8079
data = response.get_json()
8180
cat_id = data["id"]
81+
8282
update_resp = self.client.put(
83-
f"/categories/{cat_id}", json={"name": "NewName"}, headers=headers
83+
f"/categories/{cat_id}",
84+
json={"name": "NewName"},
85+
headers=create_authenticated_headers(),
8486
)
8587

8688
assert update_resp.status_code == 200
@@ -112,11 +114,13 @@ def test_update_category_duplicate_name(
112114
self._verify_category_in_db("NewName")
113115

114116
def test_delete_category(self, create_authenticated_headers, create_category):
115-
headers = create_authenticated_headers()
116-
response = create_category("ToDelete", headers=headers)
117+
response = create_category("ToDelete")
117118
data = response.get_json()
118119
cat_id = data["id"]
119-
delete_resp = self.client.delete(f"/categories/{cat_id}", headers=headers)
120+
121+
delete_resp = self.client.delete(
122+
f"/categories/{cat_id}", headers=create_authenticated_headers()
123+
)
120124

121125
assert delete_resp.status_code == 204
122126
get_resp = self.client.get(f"/categories/{cat_id}")

tests/test_product.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,14 @@ def test_get_all_products(self, create_product):
7171
assert "B" in names
7272

7373
def test_update_product(self, create_authenticated_headers, create_product):
74-
headers = create_authenticated_headers()
75-
response = create_product("OldProduct", "OldDesc", headers=headers)
74+
response = create_product("OldProduct", "OldDesc")
7675
data = response.get_json()
7776
p_id = data["id"]
77+
7878
update_resp = self.client.put(
79-
f"/product/{p_id}/update", json={"name": "NewProduct", "description": "NewDesc"}, headers=headers
79+
f"/product/{p_id}/update",
80+
json={"name": "NewProduct", "description": "NewDesc"},
81+
headers=create_authenticated_headers(),
8082
)
8183

8284
assert update_resp.status_code == 201
@@ -88,11 +90,13 @@ def test_update_product(self, create_authenticated_headers, create_product):
8890
self._verify_product_in_db("OldProduct", should_exist=False)
8991

9092
def test_delete_product(self, create_authenticated_headers, create_product):
91-
headers = create_authenticated_headers()
92-
response = create_product("ToDelete", "desc", headers=headers)
93+
response = create_product("ToDelete", "desc")
9394
data = response.get_json()
9495
p_id = data["id"]
95-
delete_resp = self.client.delete(f"/product/{p_id}", headers=headers)
96+
97+
delete_resp = self.client.delete(
98+
f"/product/{p_id}", headers=create_authenticated_headers()
99+
)
96100

97101
assert delete_resp.status_code == 200
98102
get_resp = self.client.get(f"/product/{p_id}")

tests/test_subcategory.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,14 @@ def test_get_all_subcategories(self, create_subcategory):
7575
assert "B" in names
7676

7777
def test_update_subcategory(self, create_authenticated_headers, create_subcategory):
78-
headers = create_authenticated_headers()
79-
response = create_subcategory("OldSubcat", headers=headers)
78+
response = create_subcategory("OldSubcat")
8079
data = response.get_json()
8180
sc_id = data["id"]
81+
8282
update_resp = self.client.put(
83-
f"/subcategories/{sc_id}", json={"name": "NewSubcat"}, headers=headers
83+
f"/subcategories/{sc_id}",
84+
json={"name": "NewSubcat"},
85+
headers=create_authenticated_headers(),
8486
)
8587

8688
assert update_resp.status_code == 200
@@ -111,11 +113,13 @@ def test_update_subcategory_duplicate_name(
111113
self._verify_subcategory_in_db("NewSubcat")
112114

113115
def test_delete_subcategory(self, create_authenticated_headers, create_subcategory):
114-
headers = create_authenticated_headers()
115-
response = create_subcategory("ToDelete", headers=headers)
116+
response = create_subcategory("ToDelete")
116117
data = response.get_json()
117118
sc_id = data["id"]
118-
delete_resp = self.client.delete(f"/subcategories/{sc_id}", headers=headers)
119+
120+
delete_resp = self.client.delete(
121+
f"/subcategories/{sc_id}", headers=create_authenticated_headers()
122+
)
119123

120124
assert delete_resp.status_code == 204
121125
get_resp = self.client.get(f"/subcategories/{sc_id}")

0 commit comments

Comments
 (0)