Return only product data by name and add test

Author: piyush-jaiswal

app/routes.py

@@ -906,15 +906,7 @@ def get_product_by_name(name):
     product = Product.query.filter(Product.name == name).first()
     if product is None:
         abort(404)
-
-    try:
-        product_json = product.to_json()
-        subcategories = Subcategory.query.filter(Subcategory.id.in_(product_json["subcategories"]))
-        c_ids = set(c.id for sc in subcategories for c in sc.categories)
-        product_json["categories"] = list(c_ids)
-        return product_json, 200
-    except:
-        return "Error occured", 500
+    return jsonify(product.to_json()), 200
 
 
 @app.route('/products', methods=['GET'])

tests/test_product.py

@@ -1,3 +1,5 @@
+from urllib.parse import quote
+
 import pytest
 
 from app.models import Product
@@ -114,6 +116,25 @@ def test_delete_product(self, create_authenticated_headers, create_product):
         assert get_resp.status_code == 404
         self._verify_product_in_db("ToDelete", should_exist=False)
 
+    def test_get_product_by_name(self, create_product):
+        product_name = "Test Product With Spaces"
+        response = create_product(product_name, "A test product with spaces")
+        assert response.status_code == 201
+        data = response.get_json()
+        p_id = data["id"]
+
+        encoded_name = quote(product_name)
+        get_resp = self.client.get(f"/product/{encoded_name}")
+        assert get_resp.status_code == 200
+        prod_data = get_resp.get_json()
+        assert prod_data["id"] == p_id
+        assert prod_data["name"] == product_name
+        assert prod_data["description"] == "A test product with spaces"
+
+        encoded_name = quote("Non Existent Product")
+        not_found_resp = self.client.get(f"/product/{encoded_name}")
+        assert not_found_resp.status_code == 404
+
     @pytest.mark.parametrize(
         "get_headers, expected_code",
         [