Skip to content

Commit fac22ed

Browse files
authored
Fix meeting not found timing and display (code4recovery#478)
1 parent 54c5768 commit fac22ed

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

public/app.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/Meeting.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export default function Meeting() {
7979
if (waitingForFilter) {
8080
return <Loading />;
8181
} else if (!meeting) {
82-
return <></>;
82+
throw new Error(strings.not_found);
8383
}
8484

8585
const sharePayload = {

src/hooks/filter.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,15 @@ export const FilterProvider = ({ children }: PropsWithChildren) => {
4444
const { slug } = useParams();
4545

4646
useEffect(() => {
47-
if (waitingForData || waitingForInput) return;
48-
49-
setFilter({
50-
filteredSlugs: [],
51-
inProgress: [],
52-
meeting: undefined,
53-
waitingForFilter: true,
54-
});
47+
if (waitingForData || waitingForInput) {
48+
setFilter({
49+
filteredSlugs: [],
50+
inProgress: [],
51+
meeting: undefined,
52+
waitingForFilter: true,
53+
});
54+
return;
55+
}
5556

5657
const matchGroups: string[][] = [];
5758
const now = DateTime.now();
@@ -225,7 +226,7 @@ export const FilterProvider = ({ children }: PropsWithChildren) => {
225226
meeting,
226227
waitingForFilter: false,
227228
});
228-
}, [meetings, input, latitude, longitude, slug]);
229+
}, [meetings, input, latitude, longitude, slug, waitingForData, waitingForInput]);
229230

230231
return (
231232
<FilterContext.Provider value={{ ...filter, alert }}>

0 commit comments

Comments
 (0)