Skip to content

Commit 7e1307b

Browse files
committed
Use pyinstaller signing workflow
1 parent 45d7611 commit 7e1307b

File tree

3 files changed

+23
-36
lines changed

3 files changed

+23
-36
lines changed

GNUmakefile

Lines changed: 19 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
# Change to your own Apple Developer ID, if you want to code-sign the resultant .app
66
TEAMID ?= ZD8TVTCXDS
7-
DEVID ?= 3rd Party Mac Developer Application: Perry Kundert ($(TEAMID))
8-
DEVIDLOC ?= Developer ID Application: Perry Kundert ($(TEAMID))
7+
#DEVID ?= 3rd Party Mac Developer Application: Perry Kundert ($(TEAMID))
8+
DEVID ?= Developer ID Application: Perry Kundert ($(TEAMID))
99
PKGID ?= 3rd Party Mac Developer Installer: Perry Kundert ($(TEAMID))
1010
BUNDLEID ?= ca.kundert.perry.SLIP39
1111
APIISSUER ?= 5f3b4519-83ae-4e01-8d31-f7db26f68290
@@ -186,18 +186,11 @@ dist/SLIP39.zip.notarization-status: dist/SLIP39.zip.notarization FORCE
186186
# o Create a ZIP archive suitable for notarization.
187187
#
188188
dist/SLIP39.zip: dist/SLIP39.app
189-
rm -f $@
190-
# grep -q "CFBundleVersion" "$</Contents/Info.plist" || sed -i "" -e 's:<dict>:<dict>\n\t<key>CFBundleVersion</key>\n\t<string>0.0.0</string>:' "$</Contents/Info.plist"
191-
# sed -i "" -e "s:0.0.0:$(VERSION):" "$</Contents/Info.plist"
192-
# cat $</Contents/Info.plist
193-
# codesign -dv -r- $<
194-
# codesign -vv $<
195-
# codesign --deep --force --options=runtime --timestamp \
196-
# --entitlements ./SLIP39.metadata/entitlements.plist \
197-
# --sign "$(DEVID)" \
198-
# $<
189+
echo "Checking signature..."; ./SLIP39.metadata/check-signature $<
190+
codesign --verify $<
199191
codesign -dv -r- $<
200192
codesign -vv $<
193+
rm -f $@
201194
/usr/bin/ditto -c -k --keepParent "$<" "$@"
202195
@ls -last dist
203196

@@ -260,29 +253,23 @@ dist/SLIP39.app: SLIP39.spec \
260253
rm -rf build $@*
261254
sed -I "" -E "s/version=.*/version='$(VERSION)',/" $<
262255
sed -I "" -E "s/'CFBundleVersion':.*/'CFBundleVersion':'$(VERSION)',/" $<
256+
sed -I "" -E "s/codesign_identity=.*/codesign_identity='$(DEVID)',/" $<
263257
pyinstaller --noconfirm $<
264258
echo "Checking signature (pyinstaller signed)..."; ./SLIP39.metadata/check-signature $@ || true
265259
codesign --verify $@
266-
codesign --deep --force \
267-
--all-architectures --options=runtime --timestamp \
268-
--sign "$(DEVID)" \
269-
$@
270-
echo "Checking signature (app code signed)..."; ./SLIP39.metadata/check-signature $@ || true
271-
codesign --verify $@
272-
codesign --deep --force \
273-
--all-architectures --options=runtime --timestamp \
274-
--entitlements ./SLIP39.metadata/entitlements.plist \
275-
--sign "$(DEVID)" \
276-
$@
277-
echo "Checking signature (app code + entitlements signed w/ $(DEVID))..."; ./SLIP39.metadata/check-signature $@ || true
278-
codesign --verify $@
279-
codesign --deep --force \
280-
--all-architectures --options=runtime --timestamp \
281-
--entitlements ./SLIP39.metadata/entitlements.plist \
282-
--sign "$(DEVIDLOC)" \
283-
$@
284-
echo "Checking signature (app code + entitlements signed w/ $(DEVIDLOC))..."; ./SLIP39.metadata/check-signature $@ || true
285-
codesign --verify $@
260+
# codesign --deep --force \
261+
# --all-architectures --options=runtime --timestamp \
262+
# --sign "$(DEVID)" \
263+
# $@
264+
# echo "Checking signature (app code signed)..."; ./SLIP39.metadata/check-signature $@ || true
265+
# codesign --verify $@
266+
# codesign --deep --force \
267+
# --all-architectures --options=runtime --timestamp \
268+
# --entitlements ./SLIP39.metadata/entitlements.plist \
269+
# --sign "$(DEVID)" \
270+
# $@
271+
# echo "Checking signature (app code + entitlements signed w/ $(DEVID))..."; ./SLIP39.metadata/check-signature $@ || true
272+
# codesign --verify $@
286273
touch $@ # try to avoid unnecessary rebuilding
287274

288275
#

SLIP39.spec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ exe = EXE(pyz,
3636
console=False,
3737
disable_windowed_traceback=False,
3838
target_arch=None,
39-
codesign_identity='3rd Party Mac Developer Application: Perry Kundert (ZD8TVTCXDS)',
39+
codesign_identity='Developer ID Application: Perry Kundert (ZD8TVTCXDS)',
4040
entitlements_file='SLIP39.metadata/entitlements.plist' )
4141
coll = COLLECT(exe,
4242
a.binaries,
@@ -49,9 +49,9 @@ coll = COLLECT(exe,
4949
app = BUNDLE(coll,
5050
name='SLIP39.app',
5151
icon='images/SLIP39.icns',
52-
version='6.5.3',
52+
version='6.5.4',
5353
info_plist={
54-
'CFBundleVersion':'6.5.3',
54+
'CFBundleVersion':'6.5.4',
5555
'LSApplicationCategoryType':'public.app-category.finance',
5656
'LSMinimumSystemVersion':'10.15.0',
5757
},

slip39/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
__version_info__ = ( 6, 5, 3 )
1+
__version_info__ = ( 6, 5, 4 )
22
__version__ = '.'.join( map( str, __version_info__ ))

0 commit comments

Comments
 (0)