kubectl-hns: Add --allowCascadingDeletion to "delete" command

Signed-off-by: Kazuki Suda <[email protected]>

Author: superbrothers

docs/user-guide/quickstart.md

@@ -680,6 +680,12 @@ team-a
 [s] indicates subnamespaces
 ```
 
+You can also do the above steps in one command run with the `kubectl-hns` plugin:
+
+```bash
+kubectl hns delete service-1 -n team-a --allowCascadingDeletion
+```
+
 There's an important difference between subnamespaces and regular child
 namespace, also known as a full namespace. A subnamespace is created by HNC due
 to an anchor being created in the parent; when that anchor is deleted, the

internal/kubectl/delete.go

@@ -25,19 +25,39 @@ import (
 var deleteCmd = &cobra.Command{
 	Use:   "delete -n PARENT CHILD",
 	Short: "Deletes a subnamespace under the given parent.",
-	Args:  cobra.ExactArgs(1),
+	Example: `# Delete the 'foo' anchor in the parent 'bar' namespace
+	kubectl hns delete foo -n bar
+
+	# Allow 'foo' to be cascading deleted and delete it
+	kubectl hns delete foo -n bar --allowCascadingDeletion`,
+	Args: cobra.ExactArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
+		nnm := args[0]
+
 		parent, _ := cmd.Flags().GetString("namespace")
 		if parent == "" {
 			fmt.Println("Error: parent must be set via --namespace or -n")
 			os.Exit(1)
 		}
 
-		client.deleteAnchor(parent, args[0])
+		allowCD, _ := cmd.Flags().GetBool("allowCascadingDeletion")
+		if allowCD {
+			hc := client.getHierarchy(nnm)
+			if hc.Spec.AllowCascadingDeletion {
+				fmt.Printf("Cascading deletion for '%s' is already set to 'true'; unchanged\n", nnm)
+			} else {
+				fmt.Printf("Allowing cascading deletion on '%s'\n", nnm)
+				hc.Spec.AllowCascadingDeletion = true
+				client.updateHierarchy(hc, fmt.Sprintf("update the hierarchical configuration of %s", nnm))
+			}
+		}
+
+		client.deleteAnchor(parent, nnm)
 	},
 }
 
 func newDeleteCmd() *cobra.Command {
 	deleteCmd.Flags().StringP("namespace", "n", "", "The parent namespace for the new subnamespace")
+	deleteCmd.Flags().BoolP("allowCascadingDeletion", "a", false, "Allows cascading deletion of its subnamespaces.")
 	return deleteCmd
 }

test/e2e/quickstart_test.go

@@ -269,6 +269,21 @@ spec:
 			"└── [s] " + nsService2
 		RunShouldContain(expected, defTimeout, "kubectl hns tree", nsTeamA)
 
+		// cascading deletion with the kubectl-hns plugin
+		CreateSubnamespace(nsService1, nsTeamA)
+		CreateSubnamespace(nsService4, nsService1)
+		expected = "" +
+			nsService1 + "\n" +
+			"└── [s] " + nsService4
+		RunShouldContain(expected, defTimeout, "kubectl hns tree", nsService1, "-n", nsTeamA)
+		MustNotRun("kubectl hns delete", nsService1, "-n", nsTeamA)
+		MustRun("kubectl hns delete", nsService1, "-n", nsTeamA, "--allowCascadingDeletion")
+		expected = "" +
+			nsTeamA + "\n" +
+			"└── [s] " + nsService2
+		// cascading deletion of its subnamespaces takes time
+		RunShouldContain(expected, cleanupTimeout, "kubectl hns tree", nsTeamA)
+
 		// Show the difference of a subns and regular child ns
 		CreateSubnamespace(nsService4, nsTeamA)
 		expected = "" +