Fix Coverity and build warnings across multiple modules (#4637)

Author: Copilot

pjlib/src/pj/os_core_unix.c

@@ -1054,7 +1054,9 @@ PJ_DEF(pj_status_t) pj_atomic_create( pj_pool_t *pool,
                                       pj_atomic_value_t initial,
                                       pj_atomic_t **ptr_atomic)
 {
+#if EMULATE_ATOMICS
     pj_status_t rc;
+#endif
     pj_atomic_t *atomic_var;
 
     atomic_var = PJ_POOL_ZALLOC_T(pool, pj_atomic_t);
@@ -1081,7 +1083,9 @@ PJ_DEF(pj_status_t) pj_atomic_create( pj_pool_t *pool,
  */
 PJ_DEF(pj_status_t) pj_atomic_destroy( pj_atomic_t *atomic_var )
 {
+#if EMULATE_ATOMICS
     pj_status_t status;
+#endif
 
     PJ_ASSERT_RETURN(atomic_var, PJ_EINVAL);
 
@@ -1101,7 +1105,9 @@ PJ_DEF(pj_status_t) pj_atomic_destroy( pj_atomic_t *atomic_var )
  */
 PJ_DEF(void) pj_atomic_set(pj_atomic_t *atomic_var, pj_atomic_value_t value)
 {
+#if EMULATE_ATOMICS
     pj_status_t status;
+#endif
 
     PJ_CHECK_STACK();
     PJ_ASSERT_ON_FAIL(atomic_var, return);

pjlib/src/pj/pool_caching.c

@@ -122,8 +122,10 @@ PJ_DEF(void) pj_caching_pool_destroy( pj_caching_pool *cp )
     }
 
     if (cp->lock) {
+        pj_status_t status;
         pj_lock_destroy(cp->lock);
-        pj_lock_create_null_mutex(NULL, "cachingpool", &cp->lock);
+        status = pj_lock_create_null_mutex(NULL, "cachingpool", &cp->lock);
+        PJ_ASSERT_ON_FAIL(status==PJ_SUCCESS, return);
     }
 }
 

pjmedia/src/test/mips_test.c

@@ -1013,6 +1013,7 @@ static pj_status_t init_l16_default(pjmedia_endpt *endpt)
     return pjmedia_codec_l16_init(endpt, 0);
 }
 
+#if PJMEDIA_CODEC_L16_HAS_8KHZ_MONO
 /* L16/8000/1 benchmark */
 static pjmedia_port* l16_8_encode_decode(pj_pool_t *pool,
                                          unsigned clock_rate,
@@ -1026,7 +1027,9 @@ static pjmedia_port* l16_8_encode_decode(pj_pool_t *pool,
                                clock_rate, channel_count,
                                samples_per_frame, flags, te);
 }
+#endif
 
+#if PJMEDIA_CODEC_L16_HAS_16KHZ_MONO
 /* L16/16000/1 benchmark */
 static pjmedia_port* l16_16_encode_decode(pj_pool_t *pool,
                                           unsigned clock_rate,
@@ -1041,6 +1044,7 @@ static pjmedia_port* l16_16_encode_decode(pj_pool_t *pool,
                                samples_per_frame, flags, te);
 }
 #endif
+#endif
 
 /***************************************************************************/
 /* WSOLA PLC mode */

pjsip-apps/src/samples/stateful_proxy.c

@@ -271,12 +271,20 @@ static pj_bool_t proxy_on_rx_request( pjsip_rx_data *rdata )
         uas_data2 = (struct uas_data*) invite_uas->mod_data[mod_tu.id];
         if (uas_data2->uac_tsx && uas_data2->uac_tsx->status_code < 200) {
             pjsip_tx_data *cancel;
+            pj_status_t status;
 
             pj_grp_lock_acquire(uas_data2->uac_tsx->grp_lock);
 
-            pjsip_endpt_create_cancel(global.endpt, uas_data2->uac_tsx->last_tx,
-                                      &cancel);
-            pjsip_endpt_send_request(global.endpt, cancel, -1, NULL, NULL);
+            status = pjsip_endpt_create_cancel(global.endpt, uas_data2->uac_tsx->last_tx,
+                                               &cancel);
+            if (status == PJ_SUCCESS) {
+                status = pjsip_endpt_send_request(global.endpt, cancel, -1, NULL, NULL);
+                if (status != PJ_SUCCESS) {
+                    PJ_LOG(4,(THIS_FILE, "Failed to send CANCEL request (%d)", status));
+                }
+            } else {
+                PJ_LOG(4,(THIS_FILE, "Failed to create CANCEL request (%d)", status));
+            }
 
             pj_grp_lock_release(uas_data2->uac_tsx->grp_lock);
         }

pjsip/src/pjsua-lib/pjsua_acc.c

@@ -4786,8 +4786,8 @@ PJ_DEF(pj_status_t) pjsua_acc_send_response(pjsua_acc_id acc_id,
     }
 
     if (msg_data) {
-        pjsip_hdr *hdr;
-        for (hdr = &msg_data->hdr_list; hdr && hdr != &msg_data->hdr_list;
+        const pjsip_hdr *hdr;
+        for (hdr = msg_data->hdr_list.next; hdr && hdr != &msg_data->hdr_list;
              hdr=hdr->next) {
             pjsip_msg_add_hdr(tdata->msg, (pjsip_hdr*)pjsip_hdr_clone(
                                                     tdata->pool, hdr));

pjsip/src/pjsua2-test/instant_messaging.cpp

@@ -105,7 +105,12 @@ InstantMessagingTests::~InstantMessagingTests()
     senderAcc.reset();
     receiverAcc.reset();
 
-    ep.libDestroy();
+    try {
+        ep.libDestroy();
+    } catch (const pj::Error& e) {
+        // Log the error but don't rethrow from destructor
+        std::cerr << "Error during libDestroy: " << e.reason << std::endl;
+    }
 }
 
 void InstantMessagingTests::immediateResponse()