Do not report packages that are masked entirely in master

Signed-off-by: Michał Górny <[email protected]>

Author: mgorny

src/pkgcheck/checks/overlays.py

@@ -160,5 +160,9 @@ class MasterPackageClobberedCheck(OverlayRepoCheck, OptionalCheck):
     def feed(self, pkgset):
         pkg = pkgset[0]
         for repo in self.options.target_repo.masters:
-            if repo.has_match(pkg.unversioned_atom):
-                yield MasterPackageClobbered(str(repo), pkg=pkg)
+            # Trigger only if at least one non-p.masked package matches,
+            # to cover for packages being moved to subordinate repo.
+            for master_pkg in repo.itermatch(pkg.unversioned_atom):
+                if not repo.masked.match(master_pkg):
+                    yield MasterPackageClobbered(str(repo), pkg=pkg)
+                    break

testdata/repos/overlay/MasterPackageClobberedCheck/MasterPackageClobberedMasked/MasterPackageClobberedMasked-1.ebuild

@@ -0,0 +1,4 @@
+DESCRIPTION="Ebuild clobbered by overlay"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+LICENSE="BSD"
+SLOT="0"

testdata/repos/overlayed/MasterPackageClobberedCheck/MasterPackageClobberedMasked/MasterPackageClobberedMasked-0.ebuild

@@ -0,0 +1,4 @@
+DESCRIPTION="Ebuild clobbered by overlay"
+HOMEPAGE="https://github.com/pkgcore/pkgcheck"
+LICENSE="BSD"
+SLOT="0"

testdata/repos/overlayed/profiles/package.mask

@@ -1 +1,4 @@
 stub/masked
+
+# Package being moved to ::overlay.
+<MasterPackageClobberedCheck/MasterPackageClobberedMasked-1