formatters: rename TerminfoHatesOurTerminal to TerminfoUnsupported

Author: radhermit

src/snakeoil/formatters.py

@@ -312,21 +312,20 @@ def bg(self, color=None):
     def flush(self):
         self.stream.flush()
 
-class TerminfoDisabled(Exception):
-    """
-    Raised if Terminfo is disabled.
 
-    Only possible to see this is you're trying to generate a formatter directly
-    yourself
-    """
 
 
-class _BogusTerminfo(ValueError):
-    """Used internally."""
 
 
-class TerminfoHatesOurTerminal(Exception):
+class TerminfoDisabled(Exception):
+    """Raised if Terminfo is disabled."""
+
+
+class _BogusTerminfo(ValueError):
+    """Internal terminfo exception."""
+
 
+class TerminfoUnsupported(Exception):
     """Raised if our terminal type is unsupported."""
 
     def __init__(self, term):
@@ -467,7 +466,7 @@ def __init__(self, stream, term=None, encoding=None):
                     curses.tigetstr('setaf'),
                     curses.tigetstr('setab'))
             except (_BogusTerminfo, curses.error) as e:
-                raise TerminfoHatesOurTerminal(self._term) from e
+                raise TerminfoUnsupported(self._term) from e
 
             if not all(self._set_color):
                 raise TerminfoDisabled(
@@ -492,7 +491,7 @@ def bg(self, color=None):
 
         @steal_docs(Formatter)
         def write(self, *args, **kwargs):
-            PlainTextFormatter.write(self, *args, **kwargs)
+            super().write(self, *args, **kwargs)
             try:
                 if self._modes:
                     self.reset(self)
@@ -548,7 +547,7 @@ def get_formatter(stream, force_color=False):
             try:
                 term = 'ansi' if force_color else None
                 return TerminfoFormatter(stream, term=term)
-            except (curses.error, TerminfoDisabled, TerminfoHatesOurTerminal):
+            except (curses.error, TerminfoDisabled, TerminfoUnsupported):
                 # This happens if TERM is unset and possibly in more cases.
                 # Just fall back to the PlainTextFormatter.
                 pass

tests/module/test_formatters.py

@@ -183,9 +183,9 @@ def test_terminfo(self):
         self._test_stream(
             stream, f, ('lala',), ('lala', '\n'))
 
-    def test_terminfo_hates_term(self):
+    def test_unsupported_term(self):
         stream = TemporaryFile()
-        with pytest.raises(formatters.TerminfoHatesOurTerminal):
+        with pytest.raises(formatters.TerminfoUnsupported):
             formatters.TerminfoFormatter(stream, term='dumb')
 
     @issue7567