feat: throw when no package.json in repo

Author: dominykas

lib/loader.js

@@ -45,9 +45,19 @@ internals.createRepositoryLoader = (repository) => {
 
             const url = `https://raw.githubusercontent.com/${parsedRepository.full_name}/HEAD/${filename}`;
 
-            const { payload } = await Wreck.get(url);
+            try {
+                const { payload } = await Wreck.get(url);
 
-            return payload;
+                return payload;
+            }
+            catch (err) {
+
+                if (err.output && err.output.statusCode === 404) {
+                    throw new Error(`${repository} does not contain a ${filename}`);
+                }
+
+                throw err;
+            }
         }
     };
 };

test/index.js

@@ -6,6 +6,7 @@ const Path = require('path');
 const Sinon = require('sinon');
 const SimpleGit = require('simple-git/promise');
 const Tmp = require('tmp');
+const Wreck = require('@hapi/wreck');
 
 const NodeSupport = require('..');
 
@@ -407,6 +408,43 @@ describe('node-support', () => {
                 });
             });
 
+            it('throws when repository does not have a package.json', async () => {
+
+                listRemoteStub
+                    .returns('9cef39d21ad229dea4b10295f55b0d9a83800b23\tHEAD\n');
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/node-support/HEAD/package.json')
+                    .reply(404)
+                    .get('/pkgjs/node-support/HEAD/.travis.yml')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', '.travis.yml')));
+
+                await expect(NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/node-support.git' }))
+                    .to.reject(`git+https://github.com/pkgjs/node-support.git does not contain a package.json`);
+            });
+
+            it('rethrows server errors', async () => {
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/node-support/HEAD/package.json')
+                    .reply(500)
+                    .get('/pkgjs/node-support/HEAD/.travis.yml')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', '.travis.yml')));
+
+                await expect(NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/node-support.git' }))
+                    .to.reject(/Response Error/);
+            });
+
+            it('rethrows generic errors', async () => {
+
+                const err = new Error('Something went wrong');
+
+                Sinon.stub(Wreck, 'get').throws(err);
+
+                await expect(NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/node-support.git' }))
+                    .to.reject('Something went wrong');
+            });
+
             it('throws when a package does not live on public github.com', async () => {
 
                 await expect(NodeSupport.detect({ repository: 'git+https://github.example.com/pkgjs/node-support.git' }))