feat: throw when repository does not match package name

Author: dominykas

lib/loader.js

@@ -36,7 +36,21 @@ internals.createPackageLoader = async (packageName) => {
 
         const repository = internals.parseRepository(packument);
 
-        return internals.createRepositoryLoader(repository);
+        const repositoryLoader = internals.createRepositoryLoader(repository);
+
+        return {
+            ...repositoryLoader,
+            loadFile: async (filename, options) => {
+
+                const result = await repositoryLoader.loadFile(filename, options);
+
+                if (filename === 'package.json' && result.name !== packageName) {
+                    throw new Error(`${repository} does not contain ${packageName}`);
+                }
+
+                return result;
+            }
+        };
     }
     catch (err) {
 
@@ -64,7 +78,7 @@ internals.createRepositoryLoader = (repository) => {
 
             return head;
         },
-        loadFile: async (filename) => {
+        loadFile: async (filename, options) => {
 
             if (parsedRepository.source !== 'github.com') {
                 throw new Error('Only github.com paths supported, feel free to PR at https://github.com/pkgjs/node-support');
@@ -73,7 +87,7 @@ internals.createRepositoryLoader = (repository) => {
             const url = `https://raw.githubusercontent.com/${parsedRepository.full_name}/HEAD/${filename}`;
 
             try {
-                const { payload } = await Wreck.get(url);
+                const { payload } = await Wreck.get(url, options);
 
                 return payload;
             }
@@ -108,15 +122,21 @@ internals.createPathLoader = async (path) => {
 
             return simpleGit.revparse(['HEAD']);
         },
-        loadFile: (filename) => {
+        loadFile: (filename, options = {}) => {
 
             const fullPath = Path.join(path, filename);
 
             if (!Fs.existsSync(fullPath)) {
                 return;
             }
 
-            return Fs.readFileSync(fullPath);
+            const buffer = Fs.readFileSync(fullPath);
+
+            if (options.json) {
+                return JSON.parse(buffer.toString());
+            }
+
+            return buffer;
         }
     };
 };

lib/package.js

@@ -7,7 +7,7 @@ exports.detect = async ({ path, repository, packageName }) => {
 
     const { loadFile, getCommit } = await Loader.create({ path, repository, packageName });
 
-    const packageJson = JSON.parse((await loadFile('package.json')).toString());
+    const packageJson = await loadFile('package.json', { json: 'force' });
 
     const { name, version, engines } = packageJson;
 

test/index.js

@@ -583,6 +583,25 @@ describe('node-support', () => {
                     engines: '>=10'
                 });
             });
+
+            it('throws when repo package name does not match', async () => {
+
+                listRemoteStub
+                    .returns('9cef39d21ad229dea4b10295f55b0d9a83800b23\tHEAD\n');
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/node-support/HEAD/package.json')
+                    .reply(200, JSON.stringify({ name: 'something-else' }))
+                    .get('/pkgjs/node-support/HEAD/.travis.yml')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', '.travis.yml')));
+
+                Nock('https://registry.npmjs.org')
+                    .get('/node-support')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')));
+
+                await expect(NodeSupport.detect({ packageName: 'node-support' }))
+                    .to.reject('git+https://github.com/pkgjs/node-support.git does not contain node-support');
+            });
         });
     });
 });