feat: add nodes from env matrix

Author: dominykas

lib/index.js

@@ -5,6 +5,32 @@ const Path = require('path');
 const Yaml = require('js-yaml');
 
 
+const internals = {};
+
+internals.detectFromTravisYaml = (travisYaml) => {
+
+    const raw = new Set();
+
+    if (travisYaml.node_js) {
+        const versions = Array.isArray(travisYaml.node_js) ? travisYaml.node_js : [travisYaml.node_js];
+
+        versions.forEach((v) => raw.add(v));
+    }
+
+    if (travisYaml.env) {
+
+        for (const env of travisYaml.env.matrix) {
+
+            const matches = env.match(/(?:NODEJS_VER|TRAVIS_NODE_VERSION)="?(node\/)?(?<version>[\w./*]+)"?/); /* hack syntax highlighter 🤦‍♂️ */
+
+            raw.add(matches.groups.version);
+        }
+    }
+
+    return { raw: [...raw] };
+};
+
+
 module.exports.detect = ({ path }) => {
 
     const packageJson = require(Path.join(path, 'package.json'));
@@ -16,8 +42,6 @@ module.exports.detect = ({ path }) => {
     return {
         name,
         version,
-        travis: {
-            raw: travisYaml.node_js
-        }
+        travis: internals.detectFromTravisYaml(travisYaml)
     };
 };

package.json

@@ -4,7 +4,7 @@
   "description": "List the Node.js versions supported by the package/repository",
   "main": "lib/index.js",
   "scripts": {
-    "test": "lab -a @hapi/code -L -t 100"
+    "test": "lab -a @hapi/code -L -p 1 -t 100"
   },
   "repository": {
     "type": "git",
@@ -20,7 +20,8 @@
     "@hapi/code": "^7.0.0",
     "@hapi/lab": "^21.0.0",
     "allow-scripts": "^1.5.2",
-    "semantic-release": "^15.14.0"
+    "semantic-release": "^15.14.0",
+    "tmp": "^0.1.0"
   },
   "dependencies": {
     "js-yaml": "^3.13.1"

test/fixtures/kangax-html-minifier.yml

@@ -0,0 +1,38 @@
+# Source: https://github.com/kangax/html-minifier/blob/51ce10f4daedb1de483ffbcccecc41be1c873da2/.travis.yml
+
+addons:
+  apt:
+    sources:
+      - ubuntu-toolchain-r-test
+    packages:
+      - libstdc++-4.9-dev
+
+language: generic
+
+matrix:
+  fast_finish: true
+
+env:
+  matrix:
+    - NODEJS_VER=node/6
+    - NODEJS_VER=node/8
+    - NODEJS_VER=node/10
+    - NODEJS_VER=node/latest
+
+before_install:
+  - git clone --branch v1.4.2 --depth 1 https://github.com/jasongin/nvs.git ~/.nvs
+  - . ~/.nvs/nvs.sh
+  - nvs --version
+
+install:
+  - nvs add $NODEJS_VER
+  - nvs use $NODEJS_VER
+  - node --version
+  - npm --version --no-update-notifier
+  - npm install --no-optional --no-save --no-update-notifier
+
+script:
+  - npm test --no-update-notifier
+
+notifications:
+  email: false

test/fixtures/nodejs-nan.yml

@@ -0,0 +1,44 @@
+os:
+  - linux
+  - osx
+language: cpp
+addons:
+  apt:
+    sources:
+    - ubuntu-toolchain-r-test
+    packages:
+    - bc
+    - g++-4.8
+env:
+  matrix:
+  - TRAVIS_NODE_VERSION="0.10"
+  - TRAVIS_NODE_VERSION="0.12"
+  - TRAVIS_NODE_VERSION="4"
+  - TRAVIS_NODE_VERSION="5"
+  - TRAVIS_NODE_VERSION="6"
+  - TRAVIS_NODE_VERSION="7"
+  - TRAVIS_NODE_VERSION="8"
+  - TRAVIS_NODE_VERSION="9"
+  - TRAVIS_NODE_VERSION="10"
+  - TRAVIS_NODE_VERSION="11"
+  - TRAVIS_NODE_VERSION="12"
+  - TRAVIS_NODE_VERSION="13"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="2.0.18"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="3.1.13"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="4.2.12"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="5.0.11"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="6.1.2"
+  - TRAVIS_NODE_VERSION="lts/*" ELECTRON_VERSION="7.0.0"
+matrix:
+  exclude:
+    - os: osx
+      env: TRAVIS_NODE_VERSION="0.12"
+install:
+  - rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm && (cd ~/.nvm && git checkout `git describe --abbrev=0 --tags`) && source ~/.nvm/nvm.sh && nvm install $TRAVIS_NODE_VERSION
+  - if [[ $TRAVIS_OS_NAME == "linux" ]]; then export CXX=g++-4.8; fi
+  - $CXX --version
+  - if [[ $TRAVIS_NODE_VERSION == "0.8" ]]; then npm config set strict-ssl false; fi
+  - if [[ -z "$ELECTRON_VERSION" && $(echo "$TRAVIS_NODE_VERSION < 4" | bc -l)  == "1" ]]; then npm install npm@2 && mv node_modules npm && npm/.bin/npm --version && npm/.bin/npm install; else npm --version && npm install; fi
+  - if [[ -z "$ELECTRON_VERSION" ]]; then node_modules/.bin/node-gyp rebuild --directory test; else node_modules/.bin/node-gyp rebuild --target=v$ELECTRON_VERSION --dist-url=https://atom.io/download/electron --directory test; fi
+script:
+  - if [[ -z "$ELECTRON_VERSION" ]]; then node_modules/.bin/tap --gc test/js/*-test.js; fi

test/fixtures/single-version.yml

@@ -0,0 +1,2 @@
+language: node_js
+node_js: "10"

test/index.js

@@ -1,20 +1,54 @@
 'use strict';
 
+const Fs = require('fs');
 const Path = require('path');
+const Tmp = require('tmp');
 
 const NodeSupport = require('..');
 
 
-const { describe, it } = exports.lab = require('@hapi/lab').script();
+const { describe, it, afterEach } = exports.lab = require('@hapi/lab').script();
 const { expect } = require('@hapi/code');
 
+
+const internals = {
+    tmpObjects: []
+};
+
+internals.prepareFixture = (travisYml) => {
+
+    const tmpObj = Tmp.dirSync({ unsafeCleanup: true });
+
+    internals.tmpObjects.push(tmpObj);
+
+    Fs.copyFileSync(Path.join(__dirname, 'fixtures', travisYml), Path.join(tmpObj.name, '.travis.yml'));
+
+    Fs.writeFileSync(Path.join(tmpObj.name, 'package.json'), JSON.stringify({
+        name: 'test-module',
+        version: '0.0.0-development'
+    }));
+
+    return tmpObj.name;
+};
+
+
 describe('node-support', () => {
 
+    afterEach(() => {
+
+        internals.tmpObjects.forEach((tmpObj) => {
+
+            tmpObj.removeCallback();
+        });
+
+        internals.tmpObjects = [];
+    });
+
     describe('detect()', () => {
 
         describe('path', () => {
 
-            it('returns node versions from .travis.yml at the path', async () => {
+            it('returns node versions from iamitcs-nodejs-nan.yml at the path', async () => {
 
                 const path = Path.join(__dirname, '..');
 
@@ -28,6 +62,51 @@ describe('node-support', () => {
                     }
                 });
             });
+
+            it('returns the single node version', async () => {
+
+                const path = internals.prepareFixture('single-version.yml');
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    travis: {
+                        raw: ['10']
+                    }
+                });
+            });
+
+            it('returns node versions from matrix env vars (NODEJS_VER)', async () => {
+
+                const path = internals.prepareFixture('kangax-html-minifier.yml');
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    travis: {
+                        raw: ['6', '8', '10', 'latest']
+                    }
+                });
+            });
+
+            it('returns node versions from matrix env vars (TRAVIS_NODE_VERSION)', async () => {
+
+                const path = internals.prepareFixture('nodejs-nan.yml');
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    travis: {
+                        raw: ['0.10', '0.12', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13', 'lts/*']
+                    }
+                });
+            });
         });
     });
 });