feat: handle edge cases

Author: dominykas

lib/index.js

@@ -17,7 +17,7 @@ internals.detectFromTravisYaml = (travisYaml) => {
         versions.forEach((v) => raw.add(v));
     }
 
-    if (travisYaml.env) {
+    if (travisYaml.env && travisYaml.env.matrix) {
 
         for (const env of travisYaml.env.matrix) {
 
@@ -27,6 +27,10 @@ internals.detectFromTravisYaml = (travisYaml) => {
         }
     }
 
+    if (!raw.size) {
+        raw.add('latest');
+    }
+
     return { raw: [...raw] };
 };
 
@@ -37,11 +41,14 @@ module.exports.detect = ({ path }) => {
 
     const { name, version } = packageJson;
 
-    const travisYaml = Yaml.safeLoad(Fs.readFileSync(Path.join(path, '.travis.yml')), { schema: Yaml.FAILSAFE_SCHEMA });
+    const result = { name, version };
+
+    const travisYamlPath = Path.join(path, '.travis.yml');
+
+    if (Fs.existsSync(travisYamlPath)) {
+        const travisYaml = Yaml.safeLoad(Fs.readFileSync(travisYamlPath), { schema: Yaml.FAILSAFE_SCHEMA });
+        result.travis = internals.detectFromTravisYaml(travisYaml);
+    }
 
-    return {
-        name,
-        version,
-        travis: internals.detectFromTravisYaml(travisYaml)
-    };
+    return result;
 };

test/fixtures/_minimal.yml

@@ -0,0 +1 @@
+language: node_js

test/fixtures/_no-env-matrix.yml

@@ -0,0 +1,3 @@
+language: node_js
+env:
+  - NO_MATRIX=true

test/fixtures/single-version.yml renamed to test/fixtures/_single-version.yml

@@ -21,7 +21,9 @@ internals.prepareFixture = (travisYml) => {
 
     internals.tmpObjects.push(tmpObj);
 
-    Fs.copyFileSync(Path.join(__dirname, 'fixtures', travisYml), Path.join(tmpObj.name, '.travis.yml'));
+    if (travisYml) {
+        Fs.copyFileSync(Path.join(__dirname, 'fixtures', travisYml), Path.join(tmpObj.name, '.travis.yml'));
+    }
 
     Fs.writeFileSync(Path.join(tmpObj.name, 'package.json'), JSON.stringify({
         name: 'test-module',
@@ -48,7 +50,7 @@ describe('node-support', () => {
 
         describe('path', () => {
 
-            it('returns node versions from .travis.yml at the path', async () => {
+            it('returns node versions from `.travis.yml` at the path', async () => {
 
                 const path = Path.join(__dirname, '..');
 
@@ -63,9 +65,21 @@ describe('node-support', () => {
                 });
             });
 
+            it('leaves out `travis` when no `.travis.yml` present', async () => {
+
+                const path = internals.prepareFixture();
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development'
+                });
+            });
+
             it('returns the single node version', async () => {
 
-                const path = internals.prepareFixture('single-version.yml');
+                const path = internals.prepareFixture('_single-version.yml');
 
                 const result = await NodeSupport.detect({ path });
 
@@ -78,6 +92,22 @@ describe('node-support', () => {
                 });
             });
 
+
+            it('returns default node version', async () => {
+
+                const path = internals.prepareFixture('_minimal.yml');
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    travis: {
+                        raw: ['latest']
+                    }
+                });
+            });
+
             it('returns node versions from matrix env vars (NODEJS_VER)', async () => {
 
                 const path = internals.prepareFixture('kangax-html-minifier.yml');
@@ -122,6 +152,21 @@ describe('node-support', () => {
                     }
                 });
             });
+
+            it('handles missing env.matrix', async () => {
+
+                const path = internals.prepareFixture('_no-env-matrix.yml');
+
+                const result = await NodeSupport.detect({ path });
+
+                expect(result).to.equal({
+                    name: 'test-module',
+                    version: '0.0.0-development',
+                    travis: {
+                        raw: ['latest']
+                    }
+                });
+            });
         });
     });
 });