refactor: extract travis module

Author: dominykas

lib/index.js

@@ -1,66 +1,21 @@
 'use strict';
 
-const Fs = require('fs');
 const Path = require('path');
-const Yaml = require('js-yaml');
 
+const Travis = require('./travis');
 
-const internals = {};
-
-internals.detectFromTravisYaml = (travisYaml) => {
-
-    const raw = new Set();
-
-    if (travisYaml.node_js) {
-        const versions = Array.isArray(travisYaml.node_js) ? travisYaml.node_js : [travisYaml.node_js];
-
-        versions.forEach((v) => raw.add(v));
-    }
-
-    if (travisYaml.env && travisYaml.env.matrix) {
-
-        for (const env of travisYaml.env.matrix) {
-
-            const matches = env.match(/(?:NODEJS_VER|TRAVIS_NODE_VERSION|NODE_VER)="?(node\/)?(?<version>[\w./*]+)"?/); /* hack syntax highlighter 🤦‍♂️ */
-
-            if (matches) {
-                raw.add(matches.groups.version);
-            }
-        }
-    }
-
-    if (travisYaml.matrix && travisYaml.matrix.include) {
-
-        const includes = Array.isArray(travisYaml.matrix.include) ? travisYaml.matrix.include : [travisYaml.matrix.include];
-        for (const include of includes) {
-
-            if (include.node_js) {
-                raw.add(include.node_js);
-            }
-        }
-    }
-
-    if (!raw.size) {
-        raw.add('latest');
-    }
-
-    return { raw: [...raw] };
-};
-
-
-module.exports.detect = ({ path }) => {
+exports.detect = ({ path }) => {
 
     const packageJson = require(Path.join(path, 'package.json'));
 
     const { name, version } = packageJson;
 
     const result = { name, version };
 
-    const travisYamlPath = Path.join(path, '.travis.yml');
+    const travis = Travis.detect({ path });
 
-    if (Fs.existsSync(travisYamlPath)) {
-        const travisYaml = Yaml.safeLoad(Fs.readFileSync(travisYamlPath), { schema: Yaml.FAILSAFE_SCHEMA });
-        result.travis = internals.detectFromTravisYaml(travisYaml);
+    if (travis) {
+        result.travis = travis;
     }
 
     return result;

lib/travis.js

@@ -0,0 +1,70 @@
+'use strict';
+
+const Fs = require('fs');
+const Path = require('path');
+const Yaml = require('js-yaml');
+
+
+const internals = {};
+
+
+internals.toArray = (v) => {
+
+    if (v === undefined) {
+        return [];
+    }
+
+    return Array.isArray(v) ? v : [v];
+};
+
+
+internals.scan = (travisYaml) => {
+
+    const raw = new Set();
+
+    for (const v of internals.toArray(travisYaml.node_js)) {
+        raw.add(v);
+    }
+
+    if (travisYaml.env) {
+
+        for (const env of internals.toArray(travisYaml.env.matrix)) {
+
+            const matches = env.match(/(?:NODEJS_VER|TRAVIS_NODE_VERSION|NODE_VER)="?(node\/)?(?<version>[\w./*]+)"?/); /* hack syntax highlighter 🤦‍♂️ */
+
+            if (matches) {
+                raw.add(matches.groups.version);
+            }
+        }
+    }
+
+    if (travisYaml.matrix) {
+
+        for (const include of internals.toArray(travisYaml.matrix.include)) {
+
+            if (include.node_js) {
+                raw.add(include.node_js);
+            }
+        }
+    }
+
+    if (!raw.size) {
+        raw.add('latest');
+    }
+
+    return { raw: [...raw] };
+};
+
+
+exports.detect = ({ path }) => {
+
+    const travisYamlPath = Path.join(path, '.travis.yml');
+
+    if (!Fs.existsSync(travisYamlPath)) {
+        return;
+    }
+
+    const travisYaml = Yaml.safeLoad(Fs.readFileSync(travisYamlPath), { schema: Yaml.FAILSAFE_SCHEMA });
+
+    return internals.scan(travisYaml);
+};