test: use nock to avoid hitting real servers

Author: dominykas

lib/loader.js

@@ -15,6 +15,10 @@ internals.createRepositoryLoader = (repository) => {
 
     return async (filename) => {
 
+        if (parsedRepository.source !== 'github.com') {
+            throw new Error('Only github.com paths supported, feel free to PR at https://github.com/pkgjs/node-support');
+        }
+
         const url = `https://raw.githubusercontent.com/${parsedRepository.full_name}/HEAD/${filename}`;
 
         const { payload } = await Wreck.get(url);

package.json

@@ -20,6 +20,7 @@
     "@hapi/code": "^7.0.0",
     "@hapi/lab": "^21.0.0",
     "allow-scripts": "^1.5.2",
+    "nock": "^11.7.2",
     "semantic-release": "^15.14.0",
     "tmp": "^0.1.0"
   },

test/index.js

@@ -1,13 +1,14 @@
 'use strict';
 
 const Fs = require('fs');
+const Nock = require('nock');
 const Path = require('path');
 const Tmp = require('tmp');
 
 const NodeSupport = require('..');
 
 
-const { describe, it, afterEach } = exports.lab = require('@hapi/lab').script();
+const { describe, it, beforeEach, afterEach } = exports.lab = require('@hapi/lab').script();
 const { expect } = require('@hapi/code');
 
 
@@ -246,8 +247,27 @@ describe('node-support', () => {
 
         describe('repository', () => {
 
+            beforeEach(() => {
+
+                if (!Nock.isActive()) {
+                    Nock.activate();
+                }
+            });
+
+            afterEach(() => {
+
+                Nock.restore();
+                Nock.cleanAll();
+            });
+
             it('returns node versions from `.travis.yml` in the repository', async () => {
 
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/node-support/HEAD/package.json')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')))
+                    .get('/pkgjs/node-support/HEAD/.travis.yml')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', '.travis.yml')));
+
                 const result = await NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/node-support.git' });
 
                 expect(result).to.equal({
@@ -258,6 +278,12 @@ describe('node-support', () => {
                     }
                 });
             });
+
+            it('throws when a package does not live on public github.com', async () => {
+
+                await expect(NodeSupport.detect({ repository: 'git+https://github.example.com/pkgjs/node-support.git' }))
+                    .to.reject('Only github.com paths supported, feel free to PR at https://github.com/pkgjs/node-support');
+            });
         });
     });
 });