fix: simplify argument handling

  - remove unneeded overhead in arg handling

  Signed-off-by: Michael Dawson <[email protected]>

Author: mhdawson

lib/cli/commands/show.js

@@ -3,11 +3,11 @@ const support = require('../../../index.js')
 
 // print out the information for a module and its
 // children
-function printModule (module, depth) {
+function printModule (module, depth, argv) {
   const pkg = module.package
   const moduleInfo = `${pkg.name}(${pkg.version})`
 
-  const supportInfo = support.getSupportData(pkg, module.path, preferCanonical, basePathOverride)
+  const supportInfo = support.getSupportData(pkg, module.path, argv.canonical, argv['base-path'])
   if (supportInfo.resolved) {
     console.log(`${' '.repeat(2 * (depth + 1))}${moduleInfo} - ${supportInfo.contents}`)
   } else {
@@ -20,8 +20,6 @@ function printModule (module, depth) {
   })
 };
 
-let preferCanonical = false
-let basePathOverride
 module.exports = function (opts) {
   return {
     command: 'show',
@@ -30,18 +28,10 @@ module.exports = function (opts) {
       return yargs
     },
     handler: function (argv) {
-      preferCanonical = false
-      if (argv.canonical) {
-        preferCanonical = true
-      }
-      basePathOverride = undefined
-      if (argv['base-path']) {
-        basePathOverride = argv['base-path']
-      }
       const Arborist = require('@npmcli/arborist')
       const arb = new Arborist()
       arb.loadActual().then(root => {
-        printModule(root, 0)
+        printModule(root, 0, argv)
       })
     }
   }