feat: tighten up schema

- Tighten up schema
- Add tests to validate tigher schema

Signed-off-by: Michael Dawson <[email protected]>

Author: mhdawson

schema.json

@@ -34,7 +34,8 @@
           }]
         },
         "backing": { "$ref": "#SupportBacking" }
-      }
+      },
+      "additionalProperties": false
     },
 
     "SemVerRange": {

test/cli/validate-local-support-json-bad2/command

@@ -0,0 +1 @@
+validate 

test/cli/validate-local-support-json-bad2/expected

@@ -0,0 +1,5 @@
+Error in support JSON
+ADDTIONAL PROPERTY should NOT have additional properties
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"best-effort"},"Xbacking":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                                             ^^^^^^^^^^ 😲  Xbacking is not expected to be here!

test/cli/validate-local-support-json-bad2/package-support.json

@@ -0,0 +1,16 @@
+{
+  "versions": [
+    {
+      "version": "*",
+      "target": {
+        "node": "supported"
+      },
+      "response": {
+        "type": "best-effort"
+      },
+      "Xbacking": {
+        "hobby": "https://github.com/pkgjs/support"
+      }
+    }
+  ]
+ }

test/cli/validate-local-support-json-bad2/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@pkgjs/support-show-local",
+  "version": "0.0.1",
+  "support": true,
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/pkgjs/support.git"
+  }
+}

test/cli/validate-local-support-json-bad3/command

@@ -0,0 +1 @@
+validate 

test/cli/validate-local-support-json-bad3/expected

@@ -0,0 +1,25 @@
+Error in support JSON
+TYPE should be array
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"Xbest-effort"},"backing":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be array
+
+ONEOF should match exactly one schema in oneOf
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"Xbest-effort"},"backing":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
+
+ENUM should be equal to one of the allowed values
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"Xbest-effort"},"backing":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                              ^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
+
+PATTERN should match pattern "regular-[1-7]"
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"Xbest-effort"},"backing":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                              ^^^^^^^^^^^^^^ 👈🏽  pattern should match pattern "regular-[1-7]"
+
+ONEOF should match exactly one schema in oneOf
+
+> 1 | {"versions":[{"version":"*","target":{"node":"supported"},"response":{"type":"Xbest-effort"},"backing":{"hobby":"https://github.com/pkgjs/support"}}]}
+    |                                                                              ^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf

test/cli/validate-local-support-json-bad3/package-support.json

@@ -0,0 +1,16 @@
+{
+  "versions": [
+    {
+      "version": "*",
+      "target": {
+        "node": "supported"
+      },
+      "response": {
+        "type": "Xbest-effort"
+      },
+      "backing": {
+        "hobby": "https://github.com/pkgjs/support"
+      }
+    }
+  ]
+ }

test/cli/validate-local-support-json-bad3/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@pkgjs/support-show-local",
+  "version": "0.0.1",
+  "support": true,
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/pkgjs/support.git"
+  }
+}